Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: chrome/browser/extensions/extension_action_storage_manager.cc

Issue 882243002: [Extensions] Make extension actions use gfx::Image over gfx::ImageSkia. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_action_storage_manager.h" 5 #include "chrome/browser/extensions/extension_action_storage_manager.h"
6 6
7 #include "base/base64.h" 7 #include "base/base64.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 dict->SetString(kTitleStorageKey, action->GetTitle(kDefaultTabId)); 162 dict->SetString(kTitleStorageKey, action->GetTitle(kDefaultTabId));
163 dict->SetString(kBadgeTextStorageKey, action->GetBadgeText(kDefaultTabId)); 163 dict->SetString(kBadgeTextStorageKey, action->GetBadgeText(kDefaultTabId));
164 dict->SetString( 164 dict->SetString(
165 kBadgeBackgroundColorStorageKey, 165 kBadgeBackgroundColorStorageKey,
166 SkColorToRawString(action->GetBadgeBackgroundColor(kDefaultTabId))); 166 SkColorToRawString(action->GetBadgeBackgroundColor(kDefaultTabId)));
167 dict->SetString(kBadgeTextColorStorageKey, 167 dict->SetString(kBadgeTextColorStorageKey,
168 SkColorToRawString(action->GetBadgeTextColor(kDefaultTabId))); 168 SkColorToRawString(action->GetBadgeTextColor(kDefaultTabId)));
169 dict->SetInteger(kAppearanceStorageKey, 169 dict->SetInteger(kAppearanceStorageKey,
170 action->GetIsVisible(kDefaultTabId) ? ACTIVE : INVISIBLE); 170 action->GetIsVisible(kDefaultTabId) ? ACTIVE : INVISIBLE);
171 171
172 gfx::ImageSkia icon = action->GetExplicitlySetIcon(kDefaultTabId); 172 gfx::ImageSkia icon =
173 action->GetExplicitlySetIcon(kDefaultTabId).AsImageSkia();
173 if (!icon.isNull()) { 174 if (!icon.isNull()) {
174 scoped_ptr<base::DictionaryValue> icon_value(new base::DictionaryValue()); 175 scoped_ptr<base::DictionaryValue> icon_value(new base::DictionaryValue());
175 for (size_t i = 0; i < extension_misc::kNumExtensionActionIconSizes; i++) { 176 for (size_t i = 0; i < extension_misc::kNumExtensionActionIconSizes; i++) {
176 const extension_misc::IconRepresentationInfo& icon_info = 177 const extension_misc::IconRepresentationInfo& icon_info =
177 extension_misc::kExtensionActionIconSizes[i]; 178 extension_misc::kExtensionActionIconSizes[i];
178 float scale = ui::GetScaleForScaleFactor(icon_info.scale); 179 float scale = ui::GetScaleForScaleFactor(icon_info.scale);
179 if (icon.HasRepresentation(scale)) { 180 if (icon.HasRepresentation(scale)) {
180 icon_value->SetString(icon_info.size_string, 181 icon_value->SetString(icon_info.size_string,
181 RepresentationToString(icon, scale)); 182 RepresentationToString(icon, scale));
182 } 183 }
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 return; 271 return;
271 272
272 SetDefaultsFromValue(dict, browser_action); 273 SetDefaultsFromValue(dict, browser_action);
273 } 274 }
274 275
275 StateStore* ExtensionActionStorageManager::GetStateStore() { 276 StateStore* ExtensionActionStorageManager::GetStateStore() {
276 return ExtensionSystem::Get(browser_context_)->state_store(); 277 return ExtensionSystem::Get(browser_context_)->state_store();
277 } 278 }
278 279
279 } // namespace extensions 280 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_action_icon_factory_unittest.cc ('k') | extensions/browser/extension_icon_image.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698