Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5960)

Unified Diff: chrome/browser/extensions/api/declarative_content/content_action_unittest.cc

Issue 882243002: [Extensions] Make extension actions use gfx::Image over gfx::ImageSkia. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/declarative_content/set_icon_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/declarative_content/content_action_unittest.cc
diff --git a/chrome/browser/extensions/api/declarative_content/content_action_unittest.cc b/chrome/browser/extensions/api/declarative_content/content_action_unittest.cc
index 4f1fd1802f8ddc303c448b0104017f2e621d9844..0f86d5fe710e11d1605241049aeb2d8500f54529 100644
--- a/chrome/browser/extensions/api/declarative_content/content_action_unittest.cc
+++ b/chrome/browser/extensions/api/declarative_content/content_action_unittest.cc
@@ -23,7 +23,8 @@
#include "ipc/ipc_message_utils.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
-#include "ui/gfx/image/image_skia.h"
+#include "third_party/skia/include/core/SkBitmap.h"
+#include "ui/gfx/image/image.h"
#include "ui/gfx/ipc/gfx_param_traits.h"
namespace extensions {
@@ -206,11 +207,11 @@ TEST(DeclarativeContentActionTest, SetIcon) {
};
// The declarative icon shouldn't exist unless the content action is applied.
- EXPECT_TRUE(page_action->GetDeclarativeIcon(tab_id).bitmap()->empty());
+ EXPECT_TRUE(page_action->GetDeclarativeIcon(tab_id).IsEmpty());
result->Apply(extension->id(), base::Time(), &apply_info);
- EXPECT_FALSE(page_action->GetDeclarativeIcon(tab_id).bitmap()->empty());
+ EXPECT_FALSE(page_action->GetDeclarativeIcon(tab_id).IsEmpty());
result->Revert(extension->id(), base::Time(), &apply_info);
- EXPECT_TRUE(page_action->GetDeclarativeIcon(tab_id).bitmap()->empty());
+ EXPECT_TRUE(page_action->GetDeclarativeIcon(tab_id).IsEmpty());
}
TEST_F(RequestContentScriptTest, MissingScripts) {
« no previous file with comments | « no previous file | chrome/browser/extensions/api/declarative_content/set_icon_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698