Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 882173005: Revert of Revert of Add Mojo interfaces for out-of-process proxy resolver. (Closed)

Created:
5 years, 10 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 10 months ago
Reviewers:
eroman, Noel Gordon
CC:
Sam McNally, chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Add Mojo interfaces for out-of-process proxy resolver. (patchset #1 id:1 of https://codereview.chromium.org/892373006/) Reason for revert: The code in this change is not linked into any binary. Test is flaky: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=device_unittests&tests=SerialConnectionTest.Cancel The likely cause of the test failure is https://chromium.googlesource.com/chromium/src/+/bc78a2320b50eba4fe397f1f838a82ad30b16cd6. The author has been informed and the test will be fixed soon. Original issue's description: > Revert of Add Mojo interfaces for out-of-process proxy resolver. (patchset #4 id:60001 of https://codereview.chromium.org/900433003/) > > Reason for revert: > http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/38575 > Broke device_unittests device_unittests SerialConnectionTest.Cancel it seems. > > Original issue's description: > > Add Mojo interfaces for out-of-process proxy resolver. > > > > See: > > https://docs.google.com/a/chromium.org/document/d/1n5hr4KJhZl2A4MicTfmyiHPdiKp7kmUoWXnRBN8SrZE/edit# > > > > BUG=11746 > > > > Committed: https://crrev.com/073e42bb7587b90594e5799fb6a4afe08a1e1561 > > Cr-Commit-Position: refs/heads/master@{#314509} > > TBR=rdsmith@chromium.org,eroman@chromium.org,sammc@chromium.org,amistry@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=11746 > > Committed: https://crrev.com/7d4ec1aa24e79406d29e0cafbb531a3fabfe815f > Cr-Commit-Position: refs/heads/master@{#314519} TBR=rdsmith@chromium.org,eroman@chromium.org,sammc@chromium.org,noel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=11746 Committed: https://crrev.com/aa16ad225b47b9734e878bb4887651332fa12a9c Cr-Commit-Position: refs/heads/master@{#314527}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -0 lines) Patch
A net/interfaces/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
A net/interfaces/host_resolver_service.mojom View 1 chunk +55 lines, -0 lines 0 comments Download
A net/interfaces/proxy_resolver_service.mojom View 1 chunk +48 lines, -0 lines 0 comments Download
M net/net.gyp View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Anand Mistry (off Chromium)
Created Revert of Revert of Add Mojo interfaces for out-of-process proxy resolver.
5 years, 10 months ago (2015-02-04 08:37:49 UTC) #1
Anand Mistry (off Chromium)
5 years, 10 months ago (2015-02-04 08:38:35 UTC) #3
Noel Gordon
LGTM
5 years, 10 months ago (2015-02-04 09:00:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882173005/1
5 years, 10 months ago (2015-02-04 09:01:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 09:02:17 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/aa16ad225b47b9734e878bb4887651332fa12a9c Cr-Commit-Position: refs/heads/master@{#314527}
5 years, 10 months ago (2015-02-04 09:03:20 UTC) #8
eroman
5 years, 10 months ago (2015-02-05 19:09:14 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698