Issue 88203002: Experimental scanner += API which takes Handle<String>.

Issue 88203002: Experimental scanner += API which takes Handle<String>. (Closed)

Created:
7 years ago by marja

Modified:
7 years ago

Reviewers:
dcarney, ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/parser

Visibility:
Public.

More Reviews

Description

Experimental scanner += API which takes Handle<String>. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18073

Patch Set 3 : Code review (ulan, dcarney) #

Total comments: 3

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -79 lines)			Patch
M	src/lexer/experimental-scanner.h	View	1 2	7 chunks	+73 lines, -29 lines	3 comments	Download
A +	src/lexer/experimental-scanner.cc	View	1 2	1 chunk	+31 lines, -27 lines	0 comments	Download
M	src/lexer/lexer-shell.cc	View		4 chunks	+30 lines, -22 lines	0 comments	Download
M	tools/gyp/v8.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/lexer_generator/code_generator.jinja	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ulan

https://codereview.chromium.org/88203002/diff/20001/src/lexer/experimental-scanner.cc File src/lexer/experimental-scanner.cc (right): https://codereview.chromium.org/88203002/diff/20001/src/lexer/experimental-scanner.cc#newcode36 src/lexer/experimental-scanner.cc:36: if (!scanners_) Either one line "if (!scanners_) return;" or ...

7 years ago (2013-11-26 13:15:47 UTC) #1

marja

-> and added a check that the string is flat when ExperimentalScanner gets it. https://codereview.chromium.org/88203002/diff/20001/src/lexer/experimental-scanner.cc ...

7 years ago (2013-11-26 13:35:05 UTC) #3

dcarney

https://codereview.chromium.org/88203002/diff/40001/src/lexer/experimental-scanner.h File src/lexer/experimental-scanner.h (right): https://codereview.chromium.org/88203002/diff/40001/src/lexer/experimental-scanner.h#newcode276 src/lexer/experimental-scanner.h:276: YYCTYPE yych; yych should be unused now https://codereview.chromium.org/88203002/diff/40001/src/lexer/experimental-scanner.h#newcode285 src/lexer/experimental-scanner.h:285: ...

7 years ago (2013-11-26 13:38:54 UTC) #5

ulan

7 years ago (2013-11-26 13:41:34 UTC) #6

Message was sent while issue was closed.

LGTM

https://codereview.chromium.org/88203002/diff/40001/src/lexer/experimental-sc...
File src/lexer/experimental-scanner.h (right):

https://codereview.chromium.org/88203002/diff/40001/src/lexer/experimental-sc...
src/lexer/experimental-scanner.h:245: ASSERT(source->IsFlat());
You can use FlattenString() instead of assert.

Expand Messages | Collapse Messages