tools/lexer_generator/code_generator.jinja - Issue 88203002: Experimental scanner += API which takes Handle<String>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/lexer_generator/code_generator.jinja

Issue 88203002: Experimental scanner += API which takes Handle<String>. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/parser

Patch Set: Code review (ulan, dcarney) Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/lexer_generator/code_generator.jinja

diff --git a/tools/lexer_generator/code_generator.jinja b/tools/lexer_generator/code_generator.jinja

index e86655dc43dbdbd1df92a172586a18aed19d8480..6ef81c2b73c78dfd3622b7b73ab0b625a783ee31 100644

--- a/tools/lexer_generator/code_generator.jinja

+++ b/tools/lexer_generator/code_generator.jinja

@@ -136,7 +136,7 @@

{%- elif encoding == 'utf8'-%}

unsigned bytes_read = 0;

const uint32_t long_char = unibrow::Utf8::CalculateValue(

- reinterpret_cast<uint8_t*>(cursor_),

+ reinterpret_cast<const uint8_t*>(cursor_),

buffer_end_ - cursor_,

&bytes_read);

cursor_ += bytes_read - 1;

« src/lexer/experimental-scanner.h ('K') | « tools/gyp/v8.gyp ('k') | no next file » | no next file with comments »