Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 881763002: Revert of Reland On Android, links inside headings should be announced as headings by TalkBack (Closed)

Created:
5 years, 11 months ago by dconnelly
Modified:
5 years, 11 months ago
Reviewers:
ramya.v, dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland On Android, links inside headings should be announced as headings by TalkBack (patchset #1 id:1 of https://codereview.chromium.org/854203003/) Reason for revert: DumpAccessibilityEventsTests are failing on Windows: http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34786 Original issue's description: > Reland On Android, links inside headings should be announced as headings by TalkBack > https://codereview.chromium.org/845663002 > > BUG=446216 > > Committed: https://crrev.com/217066c608ea473d2ac70e737c69ff11a0425d44 > Cr-Commit-Position: refs/heads/master@{#313248} TBR=dmazzoni@chromium.org,ramya.v@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=446216 Committed: https://crrev.com/6a1cfdb774e2cf4c4a4137ea29d11345985028cf Cr-Commit-Position: refs/heads/master@{#313259}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M content/browser/accessibility/browser_accessibility_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
D content/test/data/accessibility/html/link-inside-heading.html View 1 chunk +0 lines, -6 lines 0 comments Download
D content/test/data/accessibility/html/link-inside-heading-expected-android.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D content/test/data/accessibility/html/link-inside-heading-expected-mac.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D content/test/data/accessibility/html/link-inside-heading-expected-win.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dconnelly
Created Revert of Reland On Android, links inside headings should be announced as headings by ...
5 years, 11 months ago (2015-01-27 11:58:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881763002/1
5 years, 11 months ago (2015-01-27 11:59:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 12:00:01 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 12:01:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a1cfdb774e2cf4c4a4137ea29d11345985028cf
Cr-Commit-Position: refs/heads/master@{#313259}

Powered by Google App Engine
This is Rietveld 408576698