On Android, links inside headings should be announced as headings by TalkBack

On Android, links inside headings should be announced as headings by TalkBack

BUG=446216
Committed: https://crrev.com/68e8e33eff3a16754b9a99681d0586041436bb62
Cr-Commit-Position: refs/heads/master@{#312086}

[ramya.v, 2015-01-09 08:28:11]

ramya.v@samsung.com changed reviewers:
+ aboxhall@chromium.org, dmazzoni@chromium.org

[ramya.v, 2015-01-09 08:28:12]

PTAL!

Thanks

[dmazzoni, 2015-01-12 07:44:43]

Almost perfect, but it should search all the way up recursively, i.e. it might
be the parent of the parent that's a heading.

For example:

<h1><table><tr><td><a href="#">Link inside of a table inside of a heading is
still a heading</a></td></tr></table></h1>

Thanks!

[ramya.v, 2015-01-12 07:54:28]

On 2015/01/12 07:44:43, dmazzoni wrote:
> Almost perfect, but it should search all the way up recursively, i.e. it might
> be the parent of the parent that's a heading.
> 
> For example:
> 
> <h1><table><tr><td><a href="#">Link inside of a table inside of a heading is
> still a heading</a></td></tr></table></h1>
> 
> Thanks!

@Dominic
Thank you for the review comments.
In the above table example, by the time child anchor is computed its parent is
already determined as heading. so ax tree will come as
android.view.View focusable focused scrollable
  android.view.View heading
    android.view.View heading
      android.view.View clickable focusable heading name="Link inside of a table
inside of a heading is still a heading Link'

checking recursively does not seem to be required. Please let me know if it is
required in any other test case.

Thanks!

[ramya.v, 2015-01-12 08:35:50]

On 2015/01/12 07:54:28, ramya.v wrote:
> On 2015/01/12 07:44:43, dmazzoni wrote:
> > Almost perfect, but it should search all the way up recursively, i.e. it
might
> > be the parent of the parent that's a heading.
> > 
> > For example:
> > 
> > <h1><table><tr><td><a href="#">Link inside of a table inside of a heading is
> > still a heading</a></td></tr></table></h1>
> > 
> > Thanks!
> 
> @Dominic
> Thank you for the review comments.
> In the above table example, by the time child anchor is computed its parent is
> already determined as heading. so ax tree will come as
> android.view.View focusable focused scrollable
>   android.view.View heading
>     android.view.View heading
>       android.view.View clickable focusable heading name="Link inside of a
table
> inside of a heading is still a heading Link'
> 
> checking recursively does not seem to be required. Please let me know if it is
> required in any other test case.
> 
> Thanks!

One more doubt, only anchor element inside heading element is to be considered
as heading? Or any element inside heading element can be treated as heading?

[dmazzoni, 2015-01-14 18:02:10]

On 2015/01/12 08:35:50, ramya.v wrote:
> On 2015/01/12 07:54:28, ramya.v wrote:
> > On 2015/01/12 07:44:43, dmazzoni wrote:
> > > Almost perfect, but it should search all the way up recursively, i.e. it
> might
> > > be the parent of the parent that's a heading.
> > > 
> > > For example:
> > > 
> > > <h1><table><tr><td><a href="#">Link inside of a table inside of a heading
is
> > > still a heading</a></td></tr></table></h1>
> > > 
> > > Thanks!
> > 
> > @Dominic
> > Thank you for the review comments.
> > In the above table example, by the time child anchor is computed its parent
is
> > already determined as heading. so ax tree will come as
> > android.view.View focusable focused scrollable
> >   android.view.View heading
> >     android.view.View heading
> >       android.view.View clickable focusable heading name="Link inside of a
> table
> > inside of a heading is still a heading Link'
> > 
> > checking recursively does not seem to be required. Please let me know if it
is
> > required in any other test case.
> > 
> > Thanks!
> 
> One more doubt, only anchor element inside heading element is to be considered
> as heading? Or any element inside heading element can be treated as heading?

I think any element in a heading can be treated as a heading. The link was just
a plausible example.

[dmazzoni, 2015-01-14 18:03:02]

lgtm

Ah, you're right - calling GetParent() will check recursively as you wrote it.
Thanks.

https://codereview.chromium.org/845663002/diff/40001/content/browser/accessib...
File content/browser/accessibility/browser_accessibility_android.cc (right):

https://codereview.chromium.org/845663002/diff/40001/content/browser/accessib...
content/browser/accessibility/browser_accessibility_android.cc:199: if(parent &&
parent->IsHeading())
nit: space after the "if" before the "("

[ramya.v, 2015-01-19 08:29:00]

The CQ bit was checked by ramya.v@samsung.com

[commit-bot: I haz the power, 2015-01-19 08:29:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/845663002/60001

[commit-bot: I haz the power, 2015-01-19 09:28:20]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-19 09:29:12]

Patchset 4 (id:??) landed as
https://crrev.com/68e8e33eff3a16754b9a99681d0586041436bb62
Cr-Commit-Position: refs/heads/master@{#312086}

[bartfab (slow), 2015-01-19 12:49:01]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/862503002/ by bartfab@chromium.org.

The reason for reverting is: This caused content_browsertests to fail on the
Android bots, e.g.:

http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/17857

C 1232.064s Main  [FAIL]
DumpAccessibilityTreeTest.AccessibilityLinkInsideHeading:
C 1232.064s Main  [WARNING:dns_config_service_posix.cc(293)] Failed to read
DnsConfig.
C 1232.065s Main  [ERROR:unix_domain_server_socket_posix.cc(106)] Not
implemented reached in virtual int
net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const
C 1232.065s Main  [WARNING:proxy_service.cc(899)] PAC support disabled because
there is no system implementation
C 1232.065s Main  Testing:
/storage/emulated/0/content/test/data/accessibility/html/link-inside-heading.html
C 1232.065s Main 
../../content/browser/accessibility/dump_accessibility_browsertest_base.cc:202:
Failure
C 1232.065s Main  Value of: is_different
C 1232.065s Main    Actual: true
C 1232.065s Main  Expected: false
C 1232.065s Main  * Line Expected
C 1232.065s Main  - ---- --------
C 1232.065s Main       1 android.webkit.WebView focusable focused scrollable
C 1232.065s Main       2     android.view.View heading
C 1232.065s Main  *    3         android.view.View clickable focusable heading
name='Link In Heading'
C 1232.065s Main       4 <-- End-of-file -->
C 1232.065s Main  
C 1232.065s Main  Actual
C 1232.065s Main  ------
C 1232.065s Main  android.webkit.WebView focusable focused scrollable
C 1232.065s Main      android.view.View heading
C 1232.066s Main          android.view.View clickable focusable heading link
name='Link In Heading'
C 1232.066s Main  <-- End-of-file -->.