Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 881383002: Return void in zoomBy plumbing to match zoomBy public API (Closed)

Created:
5 years, 10 months ago by paulmiller
Modified:
5 years, 10 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Return void in zoomBy plumbing to match zoomBy public API BUG=410900 Committed: https://crrev.com/5977b553b30e6702bbbbe3da4862fd8afecf49a9 Cr-Commit-Position: refs/heads/master@{#313617}

Patch Set 1 #

Patch Set 2 : always return true from WebViewChromium.zoomBy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java View 1 1 chunk +4 lines, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 3 chunks +7 lines, -5 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwZoomTest.java View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
paulmiller
This passes android.webkit.cts.WebViewTest#testZoom.
5 years, 10 months ago (2015-01-28 19:06:17 UTC) #2
sgurun-gerrit only
On 2015/01/28 19:06:17, paulmiller wrote: > This passes android.webkit.cts.WebViewTest#testZoom. lgtm
5 years, 10 months ago (2015-01-28 20:33:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881383002/20001
5 years, 10 months ago (2015-01-28 20:36:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/29726)
5 years, 10 months ago (2015-01-28 22:18:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881383002/20001
5 years, 10 months ago (2015-01-28 23:01:43 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-28 23:37:24 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 23:39:05 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5977b553b30e6702bbbbe3da4862fd8afecf49a9
Cr-Commit-Position: refs/heads/master@{#313617}

Powered by Google App Engine
This is Rietveld 408576698