Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwZoomTest.java

Issue 881383002: Return void in zoomBy plumbing to match zoomBy public API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: always return true from WebViewChromium.zoomBy Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContents.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwZoomTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwZoomTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwZoomTest.java
index 50d978c657bcf40f44694afe64966533c7f2a943..e6d91fef99c5695a4cb20da26c8995416e395002 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwZoomTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwZoomTest.java
@@ -120,12 +120,12 @@ public class AwZoomTest extends AwTestBase {
private void zoomByOnUiThreadAndWait(final float delta) throws Throwable {
final float previousScale = getPixelScaleOnUiThread(mAwContents);
- assertTrue(runTestOnUiThreadAndGetResult(new Callable<Boolean>() {
+ ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@Override
- public Boolean call() throws Exception {
- return mAwContents.zoomBy(delta);
+ public void run() {
+ mAwContents.zoomBy(delta);
}
- }));
+ });
// The zoom level is updated asynchronously.
waitForScaleChange(previousScale);
}
« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContents.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698