Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

Issue 881383002: Return void in zoomBy plumbing to match zoomBy public API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: always return true from WebViewChromium.zoomBy Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
index caafebc82e1be3a18f08424adcb1e8ab06c1bd12..79424ec12ab1fba5441e6f62eb569781043c7d72 100644
--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
@@ -1448,12 +1448,15 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
return mAwContents.zoomOut();
}
+ // TODO(paulmiller) Return void for consistency with AwContents.zoomBy and WebView.zoomBy -
+ // tricky because frameworks WebViewProvider.zoomBy must change simultaneously
@Override
public boolean zoomBy(float factor) {
mFactory.startYourEngines(true);
// This is an L API and therefore we can enforce stricter threading constraints.
checkThread();
- return mAwContents.zoomBy(factor);
+ mAwContents.zoomBy(factor);
+ return true;
}
@Override
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698