Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 881263002: DevTools: use target-based model accessors only. (Closed)

Created:
5 years, 10 months ago by pfeldman
Modified:
5 years, 10 months ago
Reviewers:
sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: use target-based model accessors only. BUG=452465 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189126

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+593 lines, -544 lines) Patch
M LayoutTests/http/tests/inspector-enabled/console-exception-while-no-inspector.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/inspector-enabled/console-log-before-frame-navigation.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector-enabled/database-open.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector-enabled/dedicated-workers-list.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector-enabled/dom-storage-open.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector-enabled/reattach-after-editing-styles.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/appcache/appcache-test.js View 4 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/inspector/console-test.js View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/inspector/debugger-test.js View 3 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/http/tests/inspector/elements-test.js View 5 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/http/tests/inspector/elements/styles/edit-css-with-source-url.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector/elements/styles/selector-line-deprecated.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/elements/styles/stylesheet-tracking.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/inspector/elements/styles/update-locations-on-filesystem-scss-load.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/fragment.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/indexeddb/database-data.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/indexeddb/database-names.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector/indexeddb/database-structure.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/indexeddb/resources-panel.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/inspector-test.js View 4 chunks +42 lines, -25 lines 0 comments Download
M LayoutTests/http/tests/inspector/modify-cross-domain-rule.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/inspector/network-preflight-options.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/network-test.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/network/download.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/inspector/network/load-resource-for-frontend.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/network/load-resource-when-paused.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector/network/network-datareceived.html View 3 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/inspector/network/network-initiator.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/network/network-initiator-from-console.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/network/network-memory-cached-resource.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/network/network-request-type.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/network/network-xhr-data-received-async-response-type-blob.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/network/x-frame-options-deny.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/inspector/resource-parameters.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/resource-tree/resource-tree-crafted-frame-add.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/resource-tree/resource-tree-errors-reload.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector/resource-tree/resource-tree-events.html View 2 chunks +11 lines, -11 lines 0 comments Download
M LayoutTests/http/tests/inspector/resource-tree/resource-tree-frame-in-crafted-frame.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/resource-tree/resource-tree-mimetype.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector/resource-tree/resource-tree-no-xhrs.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/resource-tree/resource-tree-test.js View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/inspector/resources-test.js View 3 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/inspector/search/sources-search-scope-in-files.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/search/sources-search-scope-many-projects.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/stylesheet-source-mapping.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/inspector/websocket/websocket-frame.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/websocket/websocket-frame-error.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/websocket/websocket-handshake.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector-enabled/sources/debugger/linkifier.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/audits/audits-panel-functional.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-clear.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-css-unterminated-comment.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-css-warnings.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-dir-global.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-eval-scoped.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-eval-throw.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/console/console-last-result.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-preserve-log.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-timestamp.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/console/inspect-html-all-collection.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/attribute-modified-ns.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/elements/dom-agent-query-selector.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/dom-search-crash.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/edit-style-attribute.html View 2 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/inspector/elements/elements-css-path.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/elements-panel-rewrite-href.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/elements-panel-search.html View 4 chunks +26 lines, -26 lines 0 comments Download
M LayoutTests/inspector/elements/hide-shortcut.html View 4 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/inspector/elements/insert-node.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/inspect-mode-shadow-text.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/inspect-pointer-events-none.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/inspect-pseudo-element.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/node-xpath.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/perform-undo-undo.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/resolve-alien-node.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/resources/iframe-load-event-iframe.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/set-attribute.html View 7 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/inspector/elements/set-outer-html-test.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/add-new-rule-inline-style-csp.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/add-new-rule-with-style-after-body.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/cached-sync-computed-styles.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/styles/disable-property-workingcopy-update.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/dynamic-style-tag.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/edit-value-inside-property.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/force-pseudo-state.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/get-set-stylesheet-text.html View 4 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/inspector/elements/styles/import-pseudoclass-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/media-emulation.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/multiple-imports-edit-crash.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/styles/perform-undo-perform-of-mergable-action.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/pseudo-elements.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/elements/styles/style-update-during-selector-edit.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/styles-add-new-rule-to-stylesheet.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/styles-formatting.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-history.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/styles-new-API.html View 4 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-test.js View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/elements/styles/stylesheet-source-url-comment.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/undo-add-new-rule.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/undo-add-property.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/undo-add-rule-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/undo-change-property.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/undo-property-toggle.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/undo-set-selector-text.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/extensions/extensions-events.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/initial-modules-load.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/load-file-resource-for-frontend.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/network/network-status-non-http.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-loader.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/profiler/webgl/webgl-get-resource-state-buffer-data.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/reveal-objects.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/runtime/runtime-es6-setSymbolPropertyValue.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/runtime/runtime-getProperties.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/runtime/runtime-localStorage-getProperties.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/runtime/runtime-setPropertyValue.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/callstack-placards-discarded.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-breakpoints-not-activated-on-reload.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-disable-add-breakpoint.html View 4 chunks +11 lines, -11 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-disable-enable.html View 3 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-scripts.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-scripts-reload.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/dynamic-script-tag.html View 4 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/live-edit.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/live-edit-breakpoints.html View 6 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/live-edit-no-reveal.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/network-uisourcecode-provider.html View 3 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/pause-in-inline-script.html View 3 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/promise-events.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/properties-special.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/resource-script-mapping.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/script-failed-to-parse.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/selected-call-frame-after-formatting-source.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/source-frame.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/source-url-comment.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/watch-expressions-panel-switch.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/sources-panel-extension-names.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/storage-panel-dom-storage.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/storage-panel-dom-storage-update.html View 5 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-auto-record.html View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/audits/AuditController.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/bindings/SASSSourceMapping.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/extensions/ExtensionPanel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/extensions/ExtensionServer.js View 9 chunks +34 lines, -15 lines 0 comments Download
M Source/devtools/front_end/main/HelpScreenUntilReload.js View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 4 chunks +15 lines, -11 lines 0 comments Download
M Source/devtools/front_end/main/Tests.js View 5 chunks +11 lines, -7 lines 0 comments Download
M Source/devtools/front_end/network/NetworkLogView.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/profiler/CanvasProfileView.js View 7 chunks +20 lines, -14 lines 0 comments Download
M Source/devtools/front_end/profiler/CanvasReplayStateView.js View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/devtools/front_end/resources/ResourcesPanel.js View 8 chunks +15 lines, -13 lines 0 comments Download
M Source/devtools/front_end/screencast/ScreencastView.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/CPUProfilerModel.js View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/devtools/front_end/sdk/CSSStyleModel.js View 2 chunks +3 lines, -7 lines 0 comments Download
M Source/devtools/front_end/sdk/ContentProviders.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sdk/DOMStorage.js View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/devtools/front_end/sdk/Database.js View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/devtools/front_end/sdk/DebuggerModel.js View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/devtools/front_end/sdk/NetworkLog.js View 2 chunks +27 lines, -6 lines 0 comments Download
M Source/devtools/front_end/sdk/PowerProfiler.js View 2 chunks +3 lines, -7 lines 0 comments Download
M Source/devtools/front_end/sdk/RemoteObject.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/sdk/ResourceTreeModel.js View 2 chunks +27 lines, -5 lines 0 comments Download
M Source/devtools/front_end/sdk/RuntimeModel.js View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/devtools/front_end/sdk/SourceMap.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sdk/Target.js View 1 chunk +4 lines, -37 lines 0 comments Download
M Source/devtools/front_end/sdk/WorkerManager.js View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/devtools/front_end/timeline/CountersGraph.js View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelinePowerGraph.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePowerOverview.js View 1 4 chunks +23 lines, -8 lines 0 comments Download
M Source/devtools/scripts/generate_protocol_externs.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
pfeldman
5 years, 10 months ago (2015-01-28 12:57:21 UTC) #2
sergeyv
lgtm
5 years, 10 months ago (2015-01-28 15:54:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881263002/20001
5 years, 10 months ago (2015-01-28 16:18:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881263002/20001
5 years, 10 months ago (2015-01-28 16:30:51 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 18:21:11 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189126

Powered by Google App Engine
This is Rietveld 408576698