Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2181)

Unified Diff: Source/devtools/front_end/profiler/CanvasReplayStateView.js

Issue 881263002: DevTools: use target-based model accessors only. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/profiler/CanvasReplayStateView.js
diff --git a/Source/devtools/front_end/profiler/CanvasReplayStateView.js b/Source/devtools/front_end/profiler/CanvasReplayStateView.js
index 736e7f72e23f426320f975677ad93d1b0be39e81..5283dcae886c567921883964aefd1388d96a4cd2 100644
--- a/Source/devtools/front_end/profiler/CanvasReplayStateView.js
+++ b/Source/devtools/front_end/profiler/CanvasReplayStateView.js
@@ -496,14 +496,15 @@ WebInspector.CanvasReplayStateView.prototype = {
{
var name = descriptor.name;
var callArgument = descriptor.value;
+ var target = this._traceLogPlayer.target();
/** @type {!Element|string} */
- var valueElement = callArgument ? WebInspector.CanvasProfileDataGridHelper.createCallArgumentElement(callArgument) : "";
+ var valueElement = callArgument ? WebInspector.CanvasProfileDataGridHelper.createCallArgumentElement(target, callArgument) : "";
/** @type {!Element|string} */
var nameElement = name;
- if (typeof descriptor.enumValueForName !== "undefined")
- nameElement = WebInspector.CanvasProfileDataGridHelper.createEnumValueElement(name, +descriptor.enumValueForName);
+ if (target && typeof descriptor.enumValueForName !== "undefined")
+ nameElement = WebInspector.CanvasProfileDataGridHelper.createEnumValueElement(target, name, +descriptor.enumValueForName);
if (descriptor.isArray && descriptor.values) {
if (typeof nameElement === "string")
« no previous file with comments | « Source/devtools/front_end/profiler/CanvasProfileView.js ('k') | Source/devtools/front_end/resources/ResourcesPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698