LayoutTests/http/tests/inspector/resources-test.js - Issue 881263002: DevTools: use target-based model accessors only.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/inspector/resources-test.js

Issue 881263002: DevTools: use target-based model accessors only. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/inspector/resource-tree/resource-tree-test.js ('k') | LayoutTests/http/tests/inspector/search/sources-search-scope-in-files.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/inspector/resources-test.js

diff --git a/LayoutTests/http/tests/inspector/resources-test.js b/LayoutTests/http/tests/inspector/resources-test.js

index ebe52578e3caf9e723bce0e2bd782ad77b1be478..9acfc16f70009d28741c1082c134fe57c9f44e30 100644

--- a/LayoutTests/http/tests/inspector/resources-test.js

+++ b/LayoutTests/http/tests/inspector/resources-test.js

@@ -9,8 +9,8 @@ InspectorTest.requestURLComparer = function(r1, r2)

InspectorTest.runAfterCachedResourcesProcessed = function(callback)

{

- if (!WebInspector.resourceTreeModel._cachedResourcesProcessed)

- WebInspector.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.CachedResourcesLoaded, callback);

+ if (!InspectorTest.resourceTreeModel._cachedResourcesProcessed)

+ InspectorTest.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.CachedResourcesLoaded, callback);

else

callback();

}

@@ -27,13 +27,13 @@ InspectorTest.runAfterResourcesAreFinished = function(resourceURLs, callback)

delete resourceURLsMap[url];

}

if (!Object.keys(resourceURLsMap).length) {

- WebInspector.resourceTreeModel.removeEventListener(WebInspector.ResourceTreeModel.EventTypes.ResourceAdded, checkResources);

+ InspectorTest.resourceTreeModel.removeEventListener(WebInspector.ResourceTreeModel.EventTypes.ResourceAdded, checkResources);

callback();

}

checkResources();

if (Object.keys(resourceURLsMap).length)

- WebInspector.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.ResourceAdded, checkResources);

+ InspectorTest.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.ResourceAdded, checkResources);

}

InspectorTest.showResource = function(resourceURL, callback)

@@ -65,7 +65,7 @@ InspectorTest.showResource = function(resourceURL, callback)

InspectorTest.resourceMatchingURL = function(resourceURL)

{

var result = null;

- WebInspector.resourceTreeModel.forAllResources(visit);

+ InspectorTest.resourceTreeModel.forAllResources(visit);

function visit(resource)

{

if (resource.url.indexOf(resourceURL) !== -1) {