[Extensions] Simplify Extension Keybinding API Tests

[Extensions] Simplify Extension Keybinding API Tests

The extension keybinding api tests currently include a lot of back-and-forth
by having an extension inject a script into a page, which changes the color, and
then injecting another script to see if the color did, in fact, change. Change
this to not rely on script injection.

Committed: https://crrev.com/1d9458041f3f84ac4a6558cd65737a73bec18dfd
Cr-Commit-Position: refs/heads/master@{#313932}

[Devlin, 2015-01-28 20:59:12]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Devlin, 2015-01-28 20:59:13]

Fulfilling the request in https://codereview.chromium.org/788053008 - sorry it
took so long to get back to this one.

[Finnur, 2015-01-29 09:38:39]

Awesome. No worries on the delay.

LGTM, two nits.

https://codereview.chromium.org/880523005/diff/1/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_keybinding_apitest.cc (right):

https://codereview.chromium.org/880523005/diff/1/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_keybinding_apitest.cc:45: // Color name of
named command for overwrite_bookmark_shortcut test extension.
nit: The comment is out of date now.

https://codereview.chromium.org/880523005/diff/1/chrome/test/data/extensions/...
File chrome/test/data/extensions/api_test/keybinding/basics/background.js
(right):

https://codereview.chromium.org/880523005/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/keybinding/basics/background.js:12:
chrome.test.sendMessage('basics command');
nit: I would probably have sent the contents of command, because it can differ
based on what key is pressed. (I know there's only one such command in this
extension, but code tends to get copied around).

[Devlin, 2015-01-29 18:52:33]

Patchset #2 (id:20001) has been deleted

[Devlin, 2015-01-30 17:21:44]

https://codereview.chromium.org/880523005/diff/1/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_keybinding_apitest.cc (right):

https://codereview.chromium.org/880523005/diff/1/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_keybinding_apitest.cc:45: // Color name of
named command for overwrite_bookmark_shortcut test extension.
On 2015/01/29 09:38:39, Finnur wrote:
> nit: The comment is out of date now.

D'oh. Tried to update them all. Done.

https://codereview.chromium.org/880523005/diff/1/chrome/test/data/extensions/...
File chrome/test/data/extensions/api_test/keybinding/basics/background.js
(right):

https://codereview.chromium.org/880523005/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/keybinding/basics/background.js:12:
chrome.test.sendMessage('basics command');
On 2015/01/29 09:38:39, Finnur wrote:
> nit: I would probably have sent the contents of command, because it can differ
> based on what key is pressed. (I know there's only one such command in this
> extension, but code tends to get copied around).

Done.

[Devlin, 2015-01-30 17:21:47]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2015-01-30 17:23:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/880523005/40001

[commit-bot: I haz the power, 2015-01-30 17:27:21]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-01-30 17:29:01]

Patchset 2 (id:??) landed as
https://crrev.com/1d9458041f3f84ac4a6558cd65737a73bec18dfd
Cr-Commit-Position: refs/heads/master@{#313932}