chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/background.js - Issue 880523005: [Extensions] Simplify Extension Keybinding API Tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/background.js

Issue 880523005: [Extensions] Simplify Extension Keybinding API Tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finnur's Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/keybinding/conflicting/manifest.json ('k') | chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/background.js

diff --git a/chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/background.js b/chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/background.js

index 105bb57a59677917f52ac47df1af7dd1661136ef..f8f9b92d7a569b2b0344c834e9309738a252c7b2 100644

--- a/chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/background.js

+++ b/chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/background.js

@@ -4,9 +4,7 @@

// Called when the user activates the command.

chrome.commands.onCommand.addListener(function(command) {

- chrome.tabs.executeScript(null, {

- code: "document.body.bgColor='" + command + "'" });

- chrome.test.notifyPass();

+ chrome.test.sendMessage(command);

});

chrome.test.notifyPass();