[Extensions] Re-enable test CommandsApiTest.PageAction

[Extensions] Re-enable test CommandsApiTest.PageAction

Update CommandsApiTest.PageAction to use an ExtensionTestMessageListener in lieu
modifying the DOM. This saves a delay (for script injection), and, hopefully,
eliminates the flakiness.

BUG=165825
Committed: https://crrev.com/a6eafec7a5adaa933252b6601822d0ab312d660a
Cr-Commit-Position: refs/heads/master@{#311223}

[Devlin, 2015-01-09 00:59:23]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Devlin, 2015-01-09 01:00:13]

On 2015/01/09 00:59:23, Devlin wrote:

Hit enter by accident before I could mention: this (or something else that's
changed since the issue arose) seems to solve the flakiness issue (on linux, at
least).  Passes 100+ times, no failures.

[Finnur, 2015-01-12 10:21:40]

LGTM, one nit and a question. Question first:

https://codereview.chromium.org/788053008/diff/1/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_keybinding_apitest.cc (right):

https://codereview.chromium.org/788053008/diff/1/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_keybinding_apitest.cc:206:
EXPECT_EQ("clicked", test_listener.message());
Love this change. So much so, in fact, that I'd like to see the background
changing go away completely. For example, there are other occurrences in this
file. Would you be willing to convert those also? If so, feel free to do so as a
follow-up.

https://codereview.chromium.org/788053008/diff/1/chrome/test/data/extensions/...
File chrome/test/data/extensions/api_test/keybinding/page_action/background.js
(right):

https://codereview.chromium.org/788053008/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/keybinding/page_action/background.js:7:
chrome.test.sendMessage('clicked');
Take a look at that extension's manifest also as it still refers to making the
page red.

[Devlin, 2015-01-12 19:35:18]

Patchset #2 (id:20001) has been deleted

[Devlin, 2015-01-12 20:39:07]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2015-01-12 20:40:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/788053008/40001

[commit-bot: I haz the power, 2015-01-12 22:51:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-12 22:51:51]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Devlin, 2015-01-12 22:52:19]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2015-01-12 22:52:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/788053008/40001

[Devlin, 2015-01-12 23:06:24]

https://codereview.chromium.org/788053008/diff/1/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_keybinding_apitest.cc (right):

https://codereview.chromium.org/788053008/diff/1/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_keybinding_apitest.cc:206:
EXPECT_EQ("clicked", test_listener.message());
On 2015/01/12 10:21:40, Finnur wrote:
> Love this change. So much so, in fact, that I'd like to see the background
> changing go away completely. For example, there are other occurrences in this
> file. Would you be willing to convert those also? If so, feel free to do so as
a
> follow-up.

Happy to do so, but will do in a follow-up so that if the test happens to still
be flaky, reverting doesn't undo all of it. :)

https://codereview.chromium.org/788053008/diff/1/chrome/test/data/extensions/...
File chrome/test/data/extensions/api_test/keybinding/page_action/background.js
(right):

https://codereview.chromium.org/788053008/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/keybinding/page_action/background.js:7:
chrome.test.sendMessage('clicked');
On 2015/01/12 10:21:40, Finnur wrote:
> Take a look at that extension's manifest also as it still refers to making the
> page red.

Done.

[commit-bot: I haz the power, 2015-01-13 01:03:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-13 01:03:24]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Devlin, 2015-01-13 01:39:10]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2015-01-13 01:40:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/788053008/40001

[commit-bot: I haz the power, 2015-01-13 03:35:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-13 03:35:20]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Devlin, 2015-01-13 05:03:19]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2015-01-13 05:04:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/788053008/40001

[commit-bot: I haz the power, 2015-01-13 06:04:34]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-01-13 06:05:23]

Patchset 2 (id:??) landed as
https://crrev.com/a6eafec7a5adaa933252b6601822d0ab312d660a
Cr-Commit-Position: refs/heads/master@{#311223}