Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 880523002: Revert of Send Windows accessibility events based on tree updates. (Closed)

Created:
5 years, 11 months ago by pauljensen
Modified:
5 years, 11 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@implicit_1_tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Send Windows accessibility events based on tree updates. (patchset #9 id:160001 of https://codereview.chromium.org/848653002/) Reason for revert: DumpAccessibilityEventsTest.AccessibilityEventsTextChanged failing frequently on Windows bots. Fails most of the time on Win8 Aura. Original issue's description: > Send Windows accessibility events based on tree updates. > > The idea of this change is to fire Win AX events > based on the AX tree changing, rather than based > on Blink firing the right event and mapping it to a > Win event. > > Store the Win-specific AX attributes (ia role, > ia state, name, value, etc.) in a struct, and when a > node is updated, compare the old value of each attribute > to the new value and fire an appropriate event for each > one (name changed, state changed, etc.). > > Handle hypertext_ similarly, and properly diff the old and new hypertext in get_oldText and get_newText. > > This enables all of the "event" tests that were > previously added to pass now, and it makes live regions > work correctly in NVDA and JAWS. > > BUG=447962 > > Committed: https://crrev.com/eb691a960bef3c2aefa38627baa7cbdde480b81e > Cr-Commit-Position: refs/heads/master@{#313052} TBR=dtseng@chromium.org,aboxhall@chromium.org,dmazzoni@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=447962 Committed: https://crrev.com/9ddab275f9681cfdef2aa1ed5b8c3d9431b58468 Cr-Commit-Position: refs/heads/master@{#313067}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+571 lines, -752 lines) Patch
M content/browser/accessibility/browser_accessibility.h View 7 chunks +17 lines, -15 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 5 chunks +37 lines, -11 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_android.cc View 5 chunks +14 lines, -18 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 3 chunks +4 lines, -9 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.cc View 2 chunks +3 lines, -14 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_win.cc View 10 chunks +28 lines, -64 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.h View 5 chunks +34 lines, -51 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 34 chunks +397 lines, -542 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_events_browsertest.cc View 3 chunks +35 lines, -23 lines 0 comments Download
M content/browser/accessibility/site_per_process_accessibility_browsertest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/test/data/accessibility/event/text-changed-expected-win.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
pauljensen
Created Revert of Send Windows accessibility events based on tree updates.
5 years, 11 months ago (2015-01-26 14:57:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880523002/1
5 years, 11 months ago (2015-01-26 14:58:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 14:58:51 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 15:00:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ddab275f9681cfdef2aa1ed5b8c3d9431b58468
Cr-Commit-Position: refs/heads/master@{#313067}

Powered by Google App Engine
This is Rietveld 408576698