Source/web/PopupContainer.h - Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/PopupContainer.h

Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: added FIXME comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/PopupContainer.h

diff --git a/Source/web/PopupContainer.h b/Source/web/PopupContainer.h

index 0fbea034a601833c016bb50a8718e82d69b608be..fe55e1c7f7fd3b555f8f9727b9dcb68ccf713bcb 100644

--- a/Source/web/PopupContainer.h

+++ b/Source/web/PopupContainer.h

@@ -119,7 +119,7 @@ public:

String getSelectedItemToolTip();

// This is public for testing.

- static IntRect layoutAndCalculateWidgetRectInternal(IntRect widgetRectInScreen, int targetControlHeight, const FloatRect& windowRect, const FloatRect& screen, bool isRTL, const int rtlOffset, const int verticalOffset, const IntSize& transformOffset, PopupContent*, bool& needToResizeView);

+ static IntRect layoutAndCalculateWidgetRectInternal(IntRect widgetRectInScreen, int targetControlHeight, const IntRect& windowRect, const IntRect& screen, bool isRTL, const int rtlOffset, const int verticalOffset, const IntSize& transformOffset, PopupContent*, bool& needToResizeView);

void disconnectClient() { m_listBox->disconnectClient(); }

« no previous file with comments | « Source/web/ChromeClientImpl.cpp ('k') | Source/web/PopupContainer.cpp » ('j') | no next file with comments »