Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2602)

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: added FIXME comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/ChromeClientImpl.h ('k') | Source/web/PopupContainer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ChromeClientImpl.cpp
diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp
index e4af0a9c8324650d2b4117757f5813ca7908a889..320af934a7ca08e645a3665173f419c64744f60b 100644
--- a/Source/web/ChromeClientImpl.cpp
+++ b/Source/web/ChromeClientImpl.cpp
@@ -58,7 +58,6 @@
#include "platform/PlatformScreen.h"
#include "platform/RuntimeEnabledFeatures.h"
#include "platform/exported/WrappedResourceRequest.h"
-#include "platform/geometry/FloatRect.h"
#include "platform/geometry/IntRect.h"
#include "platform/graphics/GraphicsLayer.h"
#include "platform/weborigin/SecurityOrigin.h"
@@ -145,13 +144,13 @@ void ChromeClientImpl::chromeDestroyed()
// Our lifetime is bound to the WebViewImpl.
}
-void ChromeClientImpl::setWindowRect(const FloatRect& r)
+void ChromeClientImpl::setWindowRect(const IntRect& r)
{
if (m_webView->client())
- m_webView->client()->setWindowRect(IntRect(r));
+ m_webView->client()->setWindowRect(r);
}
-FloatRect ChromeClientImpl::windowRect()
+IntRect ChromeClientImpl::windowRect()
{
WebRect rect;
if (m_webView->client())
@@ -163,10 +162,10 @@ FloatRect ChromeClientImpl::windowRect()
rect.width = m_webView->size().width;
rect.height = m_webView->size().height;
}
- return FloatRect(rect);
+ return IntRect(rect);
}
-FloatRect ChromeClientImpl::pageRect()
+IntRect ChromeClientImpl::pageRect()
{
// We hide the details of the window's border thickness from the web page by
// simple re-using the window position here. So, from the point-of-view of
« no previous file with comments | « Source/web/ChromeClientImpl.h ('k') | Source/web/PopupContainer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698