Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: Source/web/PopupContainer.h

Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: added FIXME comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/ChromeClientImpl.cpp ('k') | Source/web/PopupContainer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright (c) 2011, Google Inc. All rights reserved. 3 * Copyright (c) 2011, Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 // The size of the font being used. 112 // The size of the font being used.
113 int menuItemFontSize() const; 113 int menuItemFontSize() const;
114 114
115 // The style of the menu being used. 115 // The style of the menu being used.
116 PopupMenuStyle menuStyle() const; 116 PopupMenuStyle menuStyle() const;
117 117
118 // While hovering popup menu window, we want to show tool tip message. 118 // While hovering popup menu window, we want to show tool tip message.
119 String getSelectedItemToolTip(); 119 String getSelectedItemToolTip();
120 120
121 // This is public for testing. 121 // This is public for testing.
122 static IntRect layoutAndCalculateWidgetRectInternal(IntRect widgetRectInScre en, int targetControlHeight, const FloatRect& windowRect, const FloatRect& scree n, bool isRTL, const int rtlOffset, const int verticalOffset, const IntSize& tra nsformOffset, PopupContent*, bool& needToResizeView); 122 static IntRect layoutAndCalculateWidgetRectInternal(IntRect widgetRectInScre en, int targetControlHeight, const IntRect& windowRect, const IntRect& screen, b ool isRTL, const int rtlOffset, const int verticalOffset, const IntSize& transfo rmOffset, PopupContent*, bool& needToResizeView);
123 123
124 void disconnectClient() { m_listBox->disconnectClient(); } 124 void disconnectClient() { m_listBox->disconnectClient(); }
125 125
126 void updateFromElement() { m_listBox->updateFromElement(); } 126 void updateFromElement() { m_listBox->updateFromElement(); }
127 127
128 virtual void trace(Visitor*) override; 128 virtual void trace(Visitor*) override;
129 129
130 private: 130 private:
131 friend class WTF::RefCounted<PopupContainer>; 131 friend class WTF::RefCounted<PopupContainer>;
132 132
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 167
168 // Whether the popup is currently open. 168 // Whether the popup is currently open.
169 bool m_popupOpen; 169 bool m_popupOpen;
170 170
171 PopupContainerClient* m_client; 171 PopupContainerClient* m_client;
172 }; 172 };
173 173
174 } // namespace blink 174 } // namespace blink
175 175
176 #endif 176 #endif
OLDNEW
« no previous file with comments | « Source/web/ChromeClientImpl.cpp ('k') | Source/web/PopupContainer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698