Source/web/ChromeClientImpl.h - Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.h

Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: added FIXME comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ChromeClientImpl.h

diff --git a/Source/web/ChromeClientImpl.h b/Source/web/ChromeClientImpl.h

index 182a36c2586ca903f628bb73b80d60c9ed9a3e78..a1439be955396edfeec35c9dcc2548f005dc7a6b 100644

--- a/Source/web/ChromeClientImpl.h

+++ b/Source/web/ChromeClientImpl.h

@@ -70,9 +70,9 @@ public:

// ChromeClient methods:

virtual void chromeDestroyed() override;

- virtual void setWindowRect(const FloatRect&) override;

- virtual FloatRect windowRect() override;

- virtual FloatRect pageRect() override;

+ virtual void setWindowRect(const IntRect&) override;

+ virtual IntRect windowRect() override;

+ virtual IntRect pageRect() override;

virtual void focus() override;

virtual bool canTakeFocus(WebFocusType) override;

virtual void takeFocus(WebFocusType) override;

« no previous file with comments | « Source/platform/PlatformScreen.cpp ('k') | Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »