Source/web/ChromeClientImpl.h - Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes

Side by Side Diff: Source/web/ChromeClientImpl.h

Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: added FIXME comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/platform/PlatformScreen.cpp ('k') | Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009 Google Inc. All rights reserved.	2 * Copyright (C) 2009 Google Inc. All rights reserved.

3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).	3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions are	6 * modification, are permitted provided that the following conditions are

7 * met:	7 * met:

8 *	8 *

9 * * Redistributions of source code must retain the above copyright	9 * * Redistributions of source code must retain the above copyright

10 * notice, this list of conditions and the following disclaimer.	10 * notice, this list of conditions and the following disclaimer.

(...skipping 52 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
63 // Handles window-level notifications from WebCore on behalf of a WebView.	63 // Handles window-level notifications from WebCore on behalf of a WebView.

64 class ChromeClientImpl final : public ChromeClient {	64 class ChromeClientImpl final : public ChromeClient {

65 public:	65 public:

66 explicit ChromeClientImpl(WebViewImpl* webView);	66 explicit ChromeClientImpl(WebViewImpl* webView);

67 virtual ~ChromeClientImpl();	67 virtual ~ChromeClientImpl();

68	68

69 virtual void* webView() const override;	69 virtual void* webView() const override;

70	70

71 // ChromeClient methods:	71 // ChromeClient methods:

72 virtual void chromeDestroyed() override;	72 virtual void chromeDestroyed() override;

73 virtual void setWindowRect(const FloatRect&) override;	73 virtual void setWindowRect(const IntRect&) override;

74 virtual FloatRect windowRect() override;	74 virtual IntRect windowRect() override;

75 virtual FloatRect pageRect() override;	75 virtual IntRect pageRect() override;

76 virtual void focus() override;	76 virtual void focus() override;

77 virtual bool canTakeFocus(WebFocusType) override;	77 virtual bool canTakeFocus(WebFocusType) override;

78 virtual void takeFocus(WebFocusType) override;	78 virtual void takeFocus(WebFocusType) override;

79 virtual void focusedNodeChanged(Node* fromNode, Node* toNode) override;	79 virtual void focusedNodeChanged(Node* fromNode, Node* toNode) override;

80 virtual void focusedFrameChanged(LocalFrame*) override;	80 virtual void focusedFrameChanged(LocalFrame*) override;

81 virtual Page* createWindow(	81 virtual Page* createWindow(

82 LocalFrame*, const FrameLoadRequest&, const WindowFeatures&, NavigationP olicy, ShouldSendReferrer) override;	82 LocalFrame*, const FrameLoadRequest&, const WindowFeatures&, NavigationP olicy, ShouldSendReferrer) override;

83 virtual void show(NavigationPolicy) override;	83 virtual void show(NavigationPolicy) override;

84 virtual bool canRunModal() override;	84 virtual bool canRunModal() override;

85 virtual void runModal() override;	85 virtual void runModal() override;

(...skipping 102 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
188 WindowFeatures m_windowFeatures;	188 WindowFeatures m_windowFeatures;

189	189

190 PagePopupDriver* m_pagePopupDriver;	190 PagePopupDriver* m_pagePopupDriver;

191 };	191 };

192	192

193 DEFINE_TYPE_CASTS(ChromeClientImpl, ChromeClient, client, client->isChromeClient Impl(), client.isChromeClientImpl());	193 DEFINE_TYPE_CASTS(ChromeClientImpl, ChromeClient, client, client->isChromeClient Impl(), client.isChromeClientImpl());

194	194

195 } // namespace blink	195 } // namespace blink

196	196

197 #endif	197 #endif

OLD	NEW