Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 879483002: [New Multicolumn] Intrinsic/preferred logical width calculation for spanners. (Closed)

Created:
5 years, 10 months ago by mstensho (USE GERRIT)
Modified:
5 years, 10 months ago
CC:
mstensho (USE GERRIT), blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[New Multicolumn] Intrinsic/preferred logical width calculation for spanners. Need to skip multicol adjustment of preferred widths when it comes to spanners. Their preferred widths should not be multiplied by the number of columns. Conversely, when encountering column-span:all renderers somewhere inside flow threads, for preferred width calculation, skip them, since they're not column content. When a multicol container asks a child spanner placeholder about its preferred logical width, relay to the actual column-span:all renderer. BUG=347325 R=jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189030

Patch Set 1 #

Total comments: 9

Patch Set 2 : Code review #

Total comments: 2

Patch Set 3 : code review #

Patch Set 4 : add assert in adjustIntrinsicLogicalWidthsForColumns() #

Total comments: 4

Patch Set 5 : final code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/dynamic/insert-spanner-into-stf-constrained-width.html View 1 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/dynamic/insert-spanner-into-stf-constrained-width-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/dynamic/insert-spanner-into-stf-unconstrained-width.html View 1 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/dynamic/insert-spanner-into-stf-unconstrained-width-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/span/preferred-widths.html View 1 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/span/preferred-widths-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/span/preferred-widths-with-column-content.html View 1 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/span/preferred-widths-with-column-content-expected.txt View 1 1 chunk +34 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 2 3 3 chunks +9 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnFlowThread.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnFlowThread.cpp View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnSpannerPlaceholder.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
mstensho (USE GERRIT)
5 years, 10 months ago (2015-01-26 12:56:03 UTC) #1
Julien - ping for review
https://codereview.chromium.org/879483002/diff/1/LayoutTests/fast/multicol/dynamic/insert-spanner-into-stf-constrained-width.html File LayoutTests/fast/multicol/dynamic/insert-spanner-into-stf-constrained-width.html (right): https://codereview.chromium.org/879483002/diff/1/LayoutTests/fast/multicol/dynamic/insert-spanner-into-stf-constrained-width.html#newcode13 LayoutTests/fast/multicol/dynamic/insert-spanner-into-stf-constrained-width.html:13: <div id="stf" style="font:20px Ahem; float:left; overflow:hidden; color:blue; background:blue;" data-expected-width="100" ...
5 years, 10 months ago (2015-01-26 14:50:13 UTC) #2
mstensho (USE GERRIT)
https://codereview.chromium.org/879483002/diff/1/LayoutTests/fast/multicol/dynamic/insert-spanner-into-stf-constrained-width.html File LayoutTests/fast/multicol/dynamic/insert-spanner-into-stf-constrained-width.html (right): https://codereview.chromium.org/879483002/diff/1/LayoutTests/fast/multicol/dynamic/insert-spanner-into-stf-constrained-width.html#newcode13 LayoutTests/fast/multicol/dynamic/insert-spanner-into-stf-constrained-width.html:13: <div id="stf" style="font:20px Ahem; float:left; overflow:hidden; color:blue; background:blue;" data-expected-width="100" ...
5 years, 10 months ago (2015-01-26 16:45:16 UTC) #3
Julien - ping for review
https://codereview.chromium.org/879483002/diff/1/Source/core/rendering/RenderMultiColumnSpannerPlaceholder.cpp File Source/core/rendering/RenderMultiColumnSpannerPlaceholder.cpp (right): https://codereview.chromium.org/879483002/diff/1/Source/core/rendering/RenderMultiColumnSpannerPlaceholder.cpp#newcode64 Source/core/rendering/RenderMultiColumnSpannerPlaceholder.cpp:64: } On 2015/01/26 16:45:15, mstensho wrote: > On 2015/01/26 ...
5 years, 10 months ago (2015-01-27 09:31:37 UTC) #4
mstensho (USE GERRIT)
I stole code from RenderBlock::adjustIntrinsicLogicalWidthsForColumns() and put it in RenderMultiColumnFlowThread::computePreferredLogicalWidths() (I could have just modified ...
5 years, 10 months ago (2015-01-27 10:20:23 UTC) #5
Julien - ping for review
lgtm https://codereview.chromium.org/879483002/diff/60001/Source/core/rendering/RenderMultiColumnFlowThread.cpp File Source/core/rendering/RenderMultiColumnFlowThread.cpp (right): https://codereview.chromium.org/879483002/diff/60001/Source/core/rendering/RenderMultiColumnFlowThread.cpp#newcode590 Source/core/rendering/RenderMultiColumnFlowThread.cpp:590: RenderBlockFlow* multicolContainer = multiColumnBlockFlow(); const RenderBlockFlow* (you're not ...
5 years, 10 months ago (2015-01-27 11:02:44 UTC) #6
mstensho (USE GERRIT)
https://codereview.chromium.org/879483002/diff/60001/Source/core/rendering/RenderMultiColumnFlowThread.cpp File Source/core/rendering/RenderMultiColumnFlowThread.cpp (right): https://codereview.chromium.org/879483002/diff/60001/Source/core/rendering/RenderMultiColumnFlowThread.cpp#newcode590 Source/core/rendering/RenderMultiColumnFlowThread.cpp:590: RenderBlockFlow* multicolContainer = multiColumnBlockFlow(); On 2015/01/27 11:02:43, Julien Chaffraix ...
5 years, 10 months ago (2015-01-27 11:54:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879483002/80001
5 years, 10 months ago (2015-01-27 11:56:15 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 13:27:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189030

Powered by Google App Engine
This is Rietveld 408576698