Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Side by Side Diff: Source/core/rendering/RenderMultiColumnFlowThread.h

Issue 879483002: [New Multicolumn] Intrinsic/preferred logical width calculation for spanners. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: final code review Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 void createAndInsertMultiColumnSet(RenderBox* insertBefore = 0); 184 void createAndInsertMultiColumnSet(RenderBox* insertBefore = 0);
185 void createAndInsertSpannerPlaceholder(RenderBox* spanner, RenderBox* insert Before = 0); 185 void createAndInsertSpannerPlaceholder(RenderBox* spanner, RenderBox* insert Before = 0);
186 virtual bool descendantIsValidColumnSpanner(RenderObject* descendant) const; 186 virtual bool descendantIsValidColumnSpanner(RenderObject* descendant) const;
187 187
188 virtual const char* renderName() const override; 188 virtual const char* renderName() const override;
189 virtual void addRegionToThread(RenderMultiColumnSet*) override; 189 virtual void addRegionToThread(RenderMultiColumnSet*) override;
190 virtual void willBeRemovedFromTree() override; 190 virtual void willBeRemovedFromTree() override;
191 virtual LayoutUnit skipColumnSpanner(RenderBox*, LayoutUnit logicalTopInFlow Thread) override; 191 virtual LayoutUnit skipColumnSpanner(RenderBox*, LayoutUnit logicalTopInFlow Thread) override;
192 virtual void flowThreadDescendantWasInserted(RenderObject*) override; 192 virtual void flowThreadDescendantWasInserted(RenderObject*) override;
193 virtual void flowThreadDescendantWillBeRemoved(RenderObject*) override; 193 virtual void flowThreadDescendantWillBeRemoved(RenderObject*) override;
194 virtual void computePreferredLogicalWidths() override;
194 virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logic alTop, LogicalExtentComputedValues&) const override; 195 virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logic alTop, LogicalExtentComputedValues&) const override;
195 virtual void updateLogicalWidth() override; 196 virtual void updateLogicalWidth() override;
196 virtual void setPageBreak(LayoutUnit offset, LayoutUnit spaceShortage) overr ide; 197 virtual void setPageBreak(LayoutUnit offset, LayoutUnit spaceShortage) overr ide;
197 virtual void updateMinimumPageHeight(LayoutUnit offset, LayoutUnit minHeight ) override; 198 virtual void updateMinimumPageHeight(LayoutUnit offset, LayoutUnit minHeight ) override;
198 virtual bool addForcedRegionBreak(LayoutUnit, RenderObject* breakChild, bool isBefore, LayoutUnit* offsetBreakAdjustment = 0) override; 199 virtual bool addForcedRegionBreak(LayoutUnit, RenderObject* breakChild, bool isBefore, LayoutUnit* offsetBreakAdjustment = 0) override;
199 virtual bool isPageLogicalHeightKnown() const override; 200 virtual bool isPageLogicalHeightKnown() const override;
200 201
201 // The last set we worked on. It's not to be used as the "current set". The concept of a 202 // The last set we worked on. It's not to be used as the "current set". The concept of a
202 // "current set" is difficult, since layout may jump back and forth in the t ree, due to wrong 203 // "current set" is difficult, since layout may jump back and forth in the t ree, due to wrong
203 // top location estimates (due to e.g. margin collapsing), and possibly for other reasons. 204 // top location estimates (due to e.g. margin collapsing), and possibly for other reasons.
204 RenderMultiColumnSet* m_lastSetWorkedOn; 205 RenderMultiColumnSet* m_lastSetWorkedOn;
205 206
206 unsigned m_columnCount; // The used value of column-count 207 unsigned m_columnCount; // The used value of column-count
207 LayoutUnit m_columnHeightAvailable; // Total height available to columns, or 0 if auto. 208 LayoutUnit m_columnHeightAvailable; // Total height available to columns, or 0 if auto.
208 bool m_inBalancingPass; // Set when relayouting for column balancing. 209 bool m_inBalancingPass; // Set when relayouting for column balancing.
209 bool m_needsColumnHeightsRecalculation; // Set when we need to recalculate t he column set heights after layout. 210 bool m_needsColumnHeightsRecalculation; // Set when we need to recalculate t he column set heights after layout.
210 bool m_progressionIsInline; // Always true for regular multicol. False for p aged-y overflow. 211 bool m_progressionIsInline; // Always true for regular multicol. False for p aged-y overflow.
211 bool m_isBeingEvacuated; 212 bool m_isBeingEvacuated;
212 }; 213 };
213 214
214 } // namespace blink 215 } // namespace blink
215 216
216 #endif // RenderMultiColumnFlowThread_h 217 #endif // RenderMultiColumnFlowThread_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderBlock.cpp ('k') | Source/core/rendering/RenderMultiColumnFlowThread.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698