Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h - Issue 879483002: [New Multicolumn] Intrinsic/preferred logical width calculation for spanners.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h

Issue 879483002: [New Multicolumn] Intrinsic/preferred logical width calculation for spanners. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: final code review Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/rendering/RenderMultiColumnFlowThread.cpp ('k') | Source/core/rendering/RenderMultiColumnSpannerPlaceholder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h

diff --git a/Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h b/Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h

index c6c7adc77a28d0343c35ad59697717bd6de4f2d0..86eb61cd4db99d572172060fa6558cbc9f16cd54 100644

--- a/Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h

+++ b/Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h

@@ -27,6 +27,8 @@ public:

protected:

virtual void willBeRemovedFromTree() override;

virtual bool needsPreferredWidthsRecalculation() const override;

+ virtual LayoutUnit minPreferredLogicalWidth() const override;

+ virtual LayoutUnit maxPreferredLogicalWidth() const override;

virtual void layout() override;

virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logicalTop, LogicalExtentComputedValues&) const override;

virtual void invalidateTreeIfNeeded(const PaintInvalidationState&) override;