Move Location to DOMWindow

Source/core/frame/LocalDOMWindow.cpp

Index: Source/core/frame/LocalDOMWindow.cpp
diff --git a/Source/core/frame/LocalDOMWindow.cpp b/Source/core/frame/LocalDOMWindow.cpp
index 4c418fe7af9bad03d3bcf06d6fabc33475395ba9..2d84951bead700acfccc160b9f3e06cd50b9b9d6 100644
--- a/Source/core/frame/LocalDOMWindow.cpp
+++ b/Source/core/frame/LocalDOMWindow.cpp
@@ -643,13 +643,14 @@ void LocalDOMWindow::reset()
     m_console = nullptr;
     m_navigator = nullptr;
     m_performance = nullptr;
-    m_location = nullptr;
     m_media = nullptr;
     m_applicationCache = nullptr;
 #if ENABLE(ASSERT)
     m_hasBeenReset = true;
 #endif
 
+    resetLocation();

[dcheng, 2015/02/10 23:02:18]

Is it still necessary to call this here? Is this because someone can try
accessing window.location on a detached window, causing this to be recreated?

[Nate Chapin, 2015/02/10 23:30:18]

This is also called at commit time. Documents shouldn't be sharing the same
location object, right?

[dcheng, 2015/02/11 00:16:13]

IIRC, this is called at commit-time on the old DOMWindow. So I guess the
question is if the old Location object should still be able to navigate the
current frame. I guess the answer is no, but this is certainly an area of the
code that could use some cleanup (I guess this kind of goes with my long-term
plans to proactively null out frame on DOMWindow).

+
     LocalDOMWindow::notifyContextDestroyed();
 }
 
@@ -783,13 +784,6 @@ Performance* LocalDOMWindow::performance() const
     return m_performance.get();
 }
 
-Location* LocalDOMWindow::location() const
-{
-    if (!m_location)
-        m_location = Location::create(frame());
-    return m_location.get();
-}
-
 void LocalDOMWindow::postMessage(PassRefPtr<SerializedScriptValue> message, const MessagePortArray* ports, const String& targetOrigin, LocalDOMWindow* source, ExceptionState& exceptionState)
 {
     if (!isCurrentlyDisplayedInFrame())
@@ -1832,7 +1826,6 @@ void LocalDOMWindow::trace(Visitor* visitor)
     visitor->trace(m_toolbar);
     visitor->trace(m_console);
     visitor->trace(m_navigator);
-    visitor->trace(m_location);
     visitor->trace(m_media);
     visitor->trace(m_applicationCache);
     visitor->trace(m_performance);