Source/core/frame/RemoteDOMWindow.cpp - Issue 879423003: Move Location to DOMWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/RemoteDOMWindow.cpp

Issue 879423003: Move Location to DOMWindow (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: resetLocation call to Frame::detach Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/RemoteDOMWindow.cpp

diff --git a/Source/core/frame/RemoteDOMWindow.cpp b/Source/core/frame/RemoteDOMWindow.cpp

index 9512e2d189a1e625a883ad0db76910257ac6b883..fefdef3d6103d0bb39acf099b323772621635615 100644

--- a/Source/core/frame/RemoteDOMWindow.cpp

+++ b/Source/core/frame/RemoteDOMWindow.cpp

@@ -9,6 +9,7 @@

#include "core/css/CSSRuleList.h"

#include "core/css/CSSStyleDeclaration.h"

#include "core/css/MediaQueryList.h"

+#include "core/frame/Location.h"

dcheng 2015/02/10 23:02:18 It's not clear to me why we need this include.

Nate Chapin 2015/02/10 23:30:18 Because I had omitted it in DOMWindow.h, will add

namespace blink {

@@ -87,12 +88,6 @@ Navigator* RemoteDOMWindow::navigator() const

return nullptr;

}

-Location* RemoteDOMWindow::location() const

- // FIXME: Implement.

- return nullptr;

bool RemoteDOMWindow::offscreenBuffering() const

{

ASSERT_NOT_REACHED();