Move Location to DOMWindow

Source/core/frame/LocalDOMWindow.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 625 matching lines @@
     m_history = nullptr;
     m_locationbar = nullptr;
     m_menubar = nullptr;
     m_personalbar = nullptr;
     m_scrollbars = nullptr;
     m_statusbar = nullptr;
     m_toolbar = nullptr;
     m_console = nullptr;
     m_navigator = nullptr;
     m_performance = nullptr;
-    m_location = nullptr;
     m_media = nullptr;
     m_applicationCache = nullptr;
 #if ENABLE(ASSERT)
     m_hasBeenReset = true;
 #endif
 
+    resetLocation();

[dcheng, 2015/02/10 23:02:18]

Is it still necessary to call this here? Is this because someone can try
accessing window.location on a detached window, causing this to be recreated?

[Nate Chapin, 2015/02/10 23:30:18]

This is also called at commit time. Documents shouldn't be sharing the same
location object, right?

[dcheng, 2015/02/11 00:16:13]

IIRC, this is called at commit-time on the old DOMWindow. So I guess the
question is if the old Location object should still be able to navigate the
current frame. I guess the answer is no, but this is certainly an area of the
code that could use some cleanup (I guess this kind of goes with my long-term
plans to proactively null out frame on DOMWindow).

+
     LocalDOMWindow::notifyContextDestroyed();
 }
 
 void LocalDOMWindow::sendOrientationChangeEvent()
 {
     ASSERT(RuntimeEnabledFeatures::orientationEventEnabled());
 
     // Before dispatching the event, build a list of the child frames to
     // also send the event to, to mitigate side effects from event handlers
     // potentially interfering with others.
@@ skipping 113 matching lines @@
     return m_navigator.get();
 }
 
 Performance* LocalDOMWindow::performance() const
 {
     if (!m_performance)
         m_performance = Performance::create(frame());
     return m_performance.get();
 }
 
-Location* LocalDOMWindow::location() const
-{
-    if (!m_location)
-        m_location = Location::create(frame());
-    return m_location.get();
-}
-
 void LocalDOMWindow::postMessage(PassRefPtr<SerializedScriptValue> message, const MessagePortArray* ports, const String& targetOrigin, LocalDOMWindow* source, ExceptionState& exceptionState)
 {
     if (!isCurrentlyDisplayedInFrame())
         return;
 
     Document* sourceDocument = source->document();
 
     // Compute the target origin.  We need to do this synchronously in order
     // to generate the SyntaxError exception correctly.
     RefPtr<SecurityOrigin> target;
@@ skipping 1022 matching lines @@
     visitor->trace(m_screen);
     visitor->trace(m_history);
     visitor->trace(m_locationbar);
     visitor->trace(m_menubar);
     visitor->trace(m_personalbar);
     visitor->trace(m_scrollbars);
     visitor->trace(m_statusbar);
     visitor->trace(m_toolbar);
     visitor->trace(m_console);
     visitor->trace(m_navigator);
-    visitor->trace(m_location);
     visitor->trace(m_media);
     visitor->trace(m_applicationCache);
     visitor->trace(m_performance);
     visitor->trace(m_css);
     visitor->trace(m_eventQueue);
     visitor->trace(m_postMessageTimers);
     HeapSupplementable<LocalDOMWindow>::trace(visitor);
 #endif
     DOMWindow::trace(visitor);
     LifecycleContext<LocalDOMWindow>::trace(visitor);
 }
 
 LocalFrame* LocalDOMWindow::frame() const
 {
     return m_frameObserver->frame();
 }
 
 v8::Handle<v8::Object> LocalDOMWindow::wrap(v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
     ASSERT_NOT_REACHED(); // LocalDOMWindow has [Custom=ToV8].
     return v8::Handle<v8::Object>();
 }
 
 } // namespace blink