Issue 879273004: Verify that code stubs and full code do not have pointers that can retain

Issue 879273004: Verify that code stubs and full code do not have pointers that can retain (Closed)

Created:
5 years, 10 months ago by ulan

Modified:
5 years, 10 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Verify that code stubs and full code do not have pointers that can retain context. BUG=v8:3629 LOG=N Committed: https://crrev.com/cd203cd6290982bf0fd686a4dbc0f36c4c310518 Cr-Commit-Position: refs/heads/master@{#26412}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -14 lines)			Patch
M	src/code-stubs.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/full-codegen.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ic/handler-compiler.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/ic/ic-compiler.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/objects-debug.cc	View	1	1 chunk	+33 lines, -12 lines	0 comments	Download

Total messages: 11 (4 generated)

Hannes Payer (out of office)

LGTM, please just add a comment what CanLeak does.

5 years, 10 months ago (2015-02-03 16:05:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879273004/1

5 years, 10 months ago (2015-02-03 16:21:55 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879273004/20001

5 years, 10 months ago (2015-02-03 16:25:08 UTC) #9

commit-bot: I haz the power

5 years, 10 months ago (2015-02-03 17:46:40 UTC) #11

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/cd203cd6290982bf0fd686a4dbc0f36c4c310518
Cr-Commit-Position: refs/heads/master@{#26412}