Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: src/ic/ic-compiler.cc

Issue 879273004: Verify that code stubs and full code do not have pointers that can retain (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add comment Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/handler-compiler.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 #include "src/ic/ic-inl.h" 8 #include "src/ic/ic-inl.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 10
(...skipping 363 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 } 374 }
375 375
376 376
377 Handle<Code> PropertyICCompiler::GetCode(Code::Kind kind, Code::StubType type, 377 Handle<Code> PropertyICCompiler::GetCode(Code::Kind kind, Code::StubType type,
378 Handle<Name> name, 378 Handle<Name> name,
379 InlineCacheState state) { 379 InlineCacheState state) {
380 Code::Flags flags = 380 Code::Flags flags =
381 Code::ComputeFlags(kind, state, extra_ic_state_, type, cache_holder()); 381 Code::ComputeFlags(kind, state, extra_ic_state_, type, cache_holder());
382 Handle<Code> code = GetCodeWithFlags(flags, name); 382 Handle<Code> code = GetCodeWithFlags(flags, name);
383 PROFILE(isolate(), CodeCreateEvent(log_kind(code), *code, *name)); 383 PROFILE(isolate(), CodeCreateEvent(log_kind(code), *code, *name));
384 #ifdef DEBUG
385 code->VerifyEmbeddedObjects();
386 #endif
384 return code; 387 return code;
385 } 388 }
386 389
387 390
388 Handle<Code> PropertyICCompiler::CompileKeyedStorePolymorphic( 391 Handle<Code> PropertyICCompiler::CompileKeyedStorePolymorphic(
389 MapHandleList* receiver_maps, KeyedAccessStoreMode store_mode) { 392 MapHandleList* receiver_maps, KeyedAccessStoreMode store_mode) {
390 // Collect MONOMORPHIC stubs for all |receiver_maps|. 393 // Collect MONOMORPHIC stubs for all |receiver_maps|.
391 CodeHandleList handlers(receiver_maps->length()); 394 CodeHandleList handlers(receiver_maps->length());
392 MapHandleList transitioned_maps(receiver_maps->length()); 395 MapHandleList transitioned_maps(receiver_maps->length());
393 for (int i = 0; i < receiver_maps->length(); ++i) { 396 for (int i = 0; i < receiver_maps->length(); ++i) {
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 460
458 TailCallBuiltin(masm(), Builtins::kKeyedStoreIC_Miss); 461 TailCallBuiltin(masm(), Builtins::kKeyedStoreIC_Miss);
459 462
460 return GetCode(kind(), Code::NORMAL, factory()->empty_string()); 463 return GetCode(kind(), Code::NORMAL, factory()->empty_string());
461 } 464 }
462 465
463 466
464 #undef __ 467 #undef __
465 } 468 }
466 } // namespace v8::internal 469 } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ic/handler-compiler.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698