src/ic/handler-compiler.cc - Issue 879273004: Verify that code stubs and full code do not have pointers that can retain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/handler-compiler.cc

Issue 879273004: Verify that code stubs and full code do not have pointers that can retain (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add comment Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/handler-compiler.cc

diff --git a/src/ic/handler-compiler.cc b/src/ic/handler-compiler.cc

index 00df7be065371c46a40f732385eeae0b12a55840..4b253af197842a7cbd549ca5692fa5170a6cfff8 100644

--- a/src/ic/handler-compiler.cc

+++ b/src/ic/handler-compiler.cc

@@ -75,6 +75,9 @@ Handle<Code> PropertyHandlerCompiler::GetCode(Code::Kind kind,

Code::Flags flags = Code::ComputeHandlerFlags(kind, type, cache_holder());

Handle<Code> code = GetCodeWithFlags(flags, name);

PROFILE(isolate(), CodeCreateEvent(Logger::STUB_TAG, *code, *name));

+#ifdef DEBUG

+ code->VerifyEmbeddedObjects();

+#endif

return code;

}

« no previous file with comments | « src/full-codegen.cc ('k') | src/ic/ic-compiler.cc » ('j') | no next file with comments »