Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 403723003: Update size expectation with ICU52 (Closed)

Created:
6 years, 5 months ago by jungshik at Google
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Update size expectation with ICU52 Update linux-rel and xp size expectations after ICU 52 roll. The size increase was signed off by laforge. Perf dashboard does not have any other size with regression due to ICU 52 update available even though I expect a similar size increase (140 - 200 kB) on Linux-rel-64 and Mac. BUG=132145 TEST=No perf size failures R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284257

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/perf_expectations/perf_expectations.json View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jungshik at Google
thakis, can you take a look just in case I made a mistake?
6 years, 5 months ago (2014-07-18 23:00:22 UTC) #1
Nico
lgtm You'll have to do this again once (if) linux64 and mac complain
6 years, 5 months ago (2014-07-18 23:03:58 UTC) #2
jungshik at Google
Committed patchset #1 manually as r284257 (presubmit successful).
6 years, 5 months ago (2014-07-18 23:58:50 UTC) #3
jungshik at Google
6 years, 5 months ago (2014-07-18 23:59:13 UTC) #4
Message was sent while issue was closed.
On 2014/07/18 23:03:58, Nico (away) wrote:
> lgtm
> 
> You'll have to do this again once (if) linux64 and mac complain

Thanks, I'll.

Powered by Google App Engine
This is Rietveld 408576698