base/i18n/break_iterator.cc - Issue 878723002: Upgrade ICU to 54.1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/i18n/break_iterator.cc

Issue 878723002: Upgrade ICU to 54.1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add en-GB display name test Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/i18n/break_iterator.cc

diff --git a/base/i18n/break_iterator.cc b/base/i18n/break_iterator.cc

index e3aaa2b5b0bafc684f444e3e4f7fe7a3e56d4018..e2ed667572f52d8b033cb9899186d73852846755 100644

--- a/base/i18n/break_iterator.cc

+++ b/base/i18n/break_iterator.cc

@@ -74,7 +74,8 @@ bool BreakIterator::Init() {

static_cast<int32_t>(string_.size()),

&status);

if (U_FAILURE(status)) {

- NOTREACHED() << "ubrk_open failed";

+ NOTREACHED() << "ubrk_open failed for type " << break_type

+ << " with error " << status;

}

« no previous file with comments | « DEPS ('k') | base/i18n/time_formatting_unittest.cc » ('j') | no next file with comments »