Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 878573004: Increase reliablity of scorllingcoordinator layout tests (Closed)

Created:
5 years, 11 months ago by majidvp
Modified:
5 years, 11 months ago
Reviewers:
Rick Byers
CC:
blink-reviews, skobes
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Increase reliability of scrolling coordinator layout tests Transformed these tests into JavaScript tests because they do not need to check render tree and compare PNGs. Also the tests wait for one frame before verifying the output which ensures |ScrollingCoordinator| has enough time to update non- fast regions. These updates should help address flakiness on Windows platform. BUG=451583 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189036

Patch Set 1 #

Patch Set 2 : Fix flakes for iframe-composited-scrolling-hide-and-show.html #

Total comments: 4

Patch Set 3 : Address review feedback #

Patch Set 4 : Update test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -85 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/iframes/iframe-composited-scrolling-hide-and-show.html View 1 1 chunk +1 line, -0 lines 0 comments Download
D LayoutTests/platform/android/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png View Binary file 0 comments Download
D LayoutTests/platform/android/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/platform/mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png View Binary file 0 comments Download
M LayoutTests/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html View 1 chunk +37 lines, -7 lines 0 comments Download
M LayoutTests/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt View 1 chunk +12 lines, -14 lines 0 comments Download
M LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html View 1 2 1 chunk +33 lines, -7 lines 0 comments Download
D LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png View Binary file 0 comments Download
M LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt View 1 2 3 1 chunk +12 lines, -16 lines 0 comments Download
M LayoutTests/scrollingcoordinator/non-fast-scrollable-visibility-change.html View 2 chunks +1 line, -10 lines 0 comments Download
M LayoutTests/scrollingcoordinator/resources/non-fast-scrollable-region-testing.js View 3 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
majidvp
5 years, 11 months ago (2015-01-26 19:54:45 UTC) #2
Rick Byers
Nice, thanks! LGTM with one minor issue and one nit. https://codereview.chromium.org/878573004/diff/20001/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html File LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html (right): https://codereview.chromium.org/878573004/diff/20001/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html#newcode11 ...
5 years, 11 months ago (2015-01-26 22:28:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878573004/40001
5 years, 11 months ago (2015-01-26 22:40:02 UTC) #5
majidvp
https://codereview.chromium.org/878573004/diff/20001/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html File LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html (right): https://codereview.chromium.org/878573004/diff/20001/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html#newcode11 LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html:11: transform:scale(2); On 2015/01/26 22:28:32, Rick Byers wrote: > nit: ...
5 years, 11 months ago (2015-01-26 22:42:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/47826)
5 years, 11 months ago (2015-01-27 00:21:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878573004/60001
5 years, 11 months ago (2015-01-27 15:54:13 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 16:00:48 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189036

Powered by Google App Engine
This is Rietveld 408576698