LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html - Issue 878573004: Increase reliablity of scorllingcoordinator layout tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html

Issue 878573004: Increase reliablity of scorllingcoordinator layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix flakes for iframe-composited-scrolling-hide-and-show.html Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt ('k') | LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <style>

3 <head>	3 iframe {

	4 position: absolute;

	5 left: 200px;

	6 top: 200px;

	7 height: 120px;

	8 width: 120px;

	9 padding: 10px;

	10 border: none;

	11 transform:scale(2);
	Rick Byers 2015/01/26 22:28:32 nit: missing space nit: missing space majidvp 2015/01/26 22:42:50 Done. Show quoted text On 2015/01/26 22:28:32, Rick Byers wrote: > nit: missing space Done.
	12 }

	13 </style>

	14

	15 <iframe src="data:text/html;charset=utf-8,<html><body style='width:1000px; heigh t:1000px;'><p style='font-size: 6px'>Should be covered by a green overlay.</p></ body></html>"></iframe>

	16 <div id="console"></div>

	17

	18 <script src="../resources/js-test.js"></script>

4 <script src="resources/non-fast-scrollable-region-testing.js"></script>	19 <script src="resources/non-fast-scrollable-region-testing.js"></script>

5 </head>	20 <script>

6 <body onload="runNonFastScrollableRegionTest();">	21 window.jsTestIsAsync = true;

7 <iframe src="data:text/html;charset=utf-8,<html><body style='width:1000px;height :1000px;'></body></html>" style="position:absolute;left:200px;top:150px;width;15 0px;height:200px;transform:scale(2);padding:10px;"></iframe>	22 description('This test ensures non-fast scrollable areas are calculated ' +

8 </body>	23 'correctly when page is scaled.');
	Rick Byers 2015/01/26 22:28:32 this description is stale - this is about a scaled this description is stale - this is about a scaled iframe majidvp 2015/01/26 22:42:50 Done. Show quoted text On 2015/01/26 22:28:32, Rick Byers wrote: > this description is stale - this is about a scaled iframe Done.
9 </html>

10	24

	25 onload = function() {

	26 awaitCompsitingUpdate(function(){

	27 nonFastScrollableRects = window.internals.nonFastScrollableRects(document) ;

	28 shouldBe('nonFastScrollableRects.length', '1');

	29 shouldBeEqualToString('rectToString(nonFastScrollableRects[0])', '[150, 15 0, 240, 240]');

	30

	31 drawNonFastScrollableRegionOverlays();

	32

	33 finishJSTest();

	34 });

	35 };

	36 </script>

OLD	NEW