LayoutTests/compositing/iframes/iframe-composited-scrolling-hide-and-show.html - Issue 878573004: Increase reliablity of scorllingcoordinator layout tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/compositing/iframes/iframe-composited-scrolling-hide-and-show.html

Issue 878573004: Increase reliablity of scorllingcoordinator layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update test expectation Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/platform/android/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/js-test.js"></script>	2 <script src="../../resources/js-test.js"></script>

3	3

4 <style>	4 <style>

5 iframe {	5 iframe {

6 height: 100px;	6 height: 100px;

7 width: 100px;	7 width: 100px;

8 }	8 }

9 </style>	9 </style>

10	10

11 <script>	11 <script>

12 description('This test makes sure hiding and showing a scrollable iframe ' +	12 description('This test makes sure hiding and showing a scrollable iframe ' +

13 'correctly updates the set of non-fast scrollable rects.');	13 'correctly updates the set of non-fast scrollable rects.');

14	14

15 onload = function() {	15 onload = function() {

16 if (window.internals) {	16 if (window.internals) {

17 var frame = document.getElementById('scrollable-iframe');	17 var frame = document.getElementById('scrollable-iframe');

	18 document.body.offsetTop; // Force layout

18 shouldBe('internals.nonFastScrollableRects(document).length', '1');	19 shouldBe('internals.nonFastScrollableRects(document).length', '1');

19 frame.style.display = 'none';	20 frame.style.display = 'none';

20 document.body.offsetTop; // Force layout	21 document.body.offsetTop; // Force layout

21 shouldBe('internals.nonFastScrollableRects(document).length', '0');	22 shouldBe('internals.nonFastScrollableRects(document).length', '0');

22 frame.style.display = '';	23 frame.style.display = '';

23 document.body.offsetTop; // Force layout	24 document.body.offsetTop; // Force layout

24 shouldBe('internals.nonFastScrollableRects(document).length', '1');	25 shouldBe('internals.nonFastScrollableRects(document).length', '1');

25 }	26 }

26 }	27 }

27 </script>	28 </script>

28	29

29 <iframe id="scrollable-iframe" src="resources/subframe.html"></iframe>	30 <iframe id="scrollable-iframe" src="resources/subframe.html"></iframe>

OLD	NEW