sky/engine/core/rendering/RenderReplaced.h - Issue 878023002: Merge outline paint phases into the foreground phase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderReplaced.h

Issue 878023002: Merge outline paint phases into the foreground phase. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sky/engine/core/rendering/RenderLayer.cpp ('K') | « sky/engine/core/rendering/RenderLayerClipper.cpp ('k') | sky/engine/core/rendering/RenderReplaced.cpp » ('j') | sky/engine/core/rendering/RenderReplaced.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/engine/core/rendering/RenderReplaced.h

diff --git a/sky/engine/core/rendering/RenderReplaced.h b/sky/engine/core/rendering/RenderReplaced.h

index 788b9e1b462f3c2d58cd7c294ceb52d63673b144..6b95147f643c21b7f13476d4159286313fc3a655 100644

--- a/sky/engine/core/rendering/RenderReplaced.h

+++ b/sky/engine/core/rendering/RenderReplaced.h

@@ -66,7 +66,7 @@ protected:

void setIntrinsicSize(const LayoutSize& intrinsicSize) { m_intrinsicSize = intrinsicSize; }

virtual void intrinsicSizeChanged();

- virtual void paint(PaintInfo&, const LayoutPoint&) override;

+ virtual void paint(PaintInfo&, const LayoutPoint&) final;

bool shouldPaint(PaintInfo&, const LayoutPoint&);

LayoutRect localSelectionRect(bool checkWhetherSelected = true) const; // This is in local coordinates, but it's a physical rect (so the top left corner is physical top left).