Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: sky/engine/core/rendering/RenderLayerClipper.cpp

Issue 878023002: Merge outline paint phases into the foreground phase. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/RenderLayerClipper.cpp
diff --git a/sky/engine/core/rendering/RenderLayerClipper.cpp b/sky/engine/core/rendering/RenderLayerClipper.cpp
index e3ec78000689151a7c64834f76574c93b4b14e9c..9446f25b347774bd610c21c50b3cd5af1859e34b 100644
--- a/sky/engine/core/rendering/RenderLayerClipper.cpp
+++ b/sky/engine/core/rendering/RenderLayerClipper.cpp
@@ -164,10 +164,10 @@ LayoutRect RenderLayerClipper::childrenClipRect() const
// FIXME: Regions not accounted for.
RenderLayer* clippingRootLayer = clippingRootForPainting();
LayoutRect layerBounds;
- ClipRect backgroundRect, foregroundRect, outlineRect;
+ ClipRect backgroundRect, foregroundRect;
// Need to use uncached clip rects, because the value of 'dontClipToOverflow' may be different from the painting path (<rdar://problem/11844909>).
ClipRectsContext context(clippingRootLayer, UncachedClipRects);
- calculateRects(context, m_renderer.view()->unscaledDocumentRect(), layerBounds, backgroundRect, foregroundRect, outlineRect);
+ calculateRects(context, m_renderer.view()->unscaledDocumentRect(), layerBounds, backgroundRect, foregroundRect);
return clippingRootLayer->renderer()->localToAbsoluteQuad(FloatQuad(foregroundRect.rect())).enclosingBoundingBox();
}
@@ -176,9 +176,9 @@ LayoutRect RenderLayerClipper::localClipRect() const
// FIXME: border-radius not accounted for.
RenderLayer* clippingRootLayer = clippingRootForPainting();
LayoutRect layerBounds;
- ClipRect backgroundRect, foregroundRect, outlineRect;
+ ClipRect backgroundRect, foregroundRect;
ClipRectsContext context(clippingRootLayer, PaintingClipRects);
- calculateRects(context, PaintInfo::infiniteRect(), layerBounds, backgroundRect, foregroundRect, outlineRect);
+ calculateRects(context, PaintInfo::infiniteRect(), layerBounds, backgroundRect, foregroundRect);
LayoutRect clipRect = backgroundRect.rect();
if (clipRect == PaintInfo::infiniteRect())
@@ -192,7 +192,7 @@ LayoutRect RenderLayerClipper::localClipRect() const
}
void RenderLayerClipper::calculateRects(const ClipRectsContext& context, const LayoutRect& paintDirtyRect, LayoutRect& layerBounds,
- ClipRect& backgroundRect, ClipRect& foregroundRect, ClipRect& outlineRect, const LayoutPoint* offsetFromRoot) const
+ ClipRect& backgroundRect, ClipRect& foregroundRect, const LayoutPoint* offsetFromRoot) const
{
bool isClippingRoot = m_renderer.layer() == context.rootLayer;
@@ -205,7 +205,6 @@ void RenderLayerClipper::calculateRects(const ClipRectsContext& context, const L
}
foregroundRect = backgroundRect;
- outlineRect = backgroundRect;
LayoutPoint offset;
if (offsetFromRoot)
@@ -244,7 +243,6 @@ void RenderLayerClipper::calculateRects(const ClipRectsContext& context, const L
LayoutRect newPosClip = toRenderBox(m_renderer).clipRect(offset);
backgroundRect.intersect(newPosClip);
foregroundRect.intersect(newPosClip);
- outlineRect.intersect(newPosClip);
}
}

Powered by Google App Engine
This is Rietveld 408576698