Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 877993004: Revert "Update mojo sdk to rev 8d45c89c30b230843c5bd6dd0693a555750946c0" (Closed)

Created:
5 years, 10 months ago by viettrungluu
Modified:
5 years, 10 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Update mojo sdk to rev 8d45c89c30b230843c5bd6dd0693a555750946c0" This reverts commit c2e11810044fe5ff1c1b8588103671925a5b74fe. TBR=viettrungluu@chromium.org NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true BUG= Committed: https://crrev.com/0e5adf14aee00d99270cfe780a4364474e952912 Cr-Commit-Position: refs/heads/master@{#315134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1088 lines, -1671 lines) Patch
M components/nacl/loader/nacl_listener.cc View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/cc/output_surface_mojo.h View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/cc/output_surface_mojo.cc View 3 chunks +4 lines, -3 lines 0 comments Download
A third_party/mojo/src/mojo/edk/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/edk/embedder/DEPS View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/channel_init.h View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/channel_init.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/embedder.h View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/embedder.cc View 5 chunks +47 lines, -42 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/embedder_internal.h View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/embedder_unittest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/test_embedder.cc View 1 chunk +0 lines, -5 lines 0 comments Download
A + third_party/mojo/src/mojo/edk/js/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/js/tests/js_to_cpp.mojom View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/js/tests/js_to_cpp_tests.cc View 4 chunks +12 lines, -20 lines 0 comments Download
M third_party/mojo/src/mojo/edk/js/tests/js_to_cpp_tests.js View 4 chunks +12 lines, -14 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/BUILD.gn View 3 chunks +2 lines, -8 lines 0 comments Download
A + third_party/mojo/src/mojo/edk/system/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel.h View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_manager.h View 2 chunks +31 lines, -65 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_manager.cc View 4 chunks +14 lines, -57 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_manager_unittest.cc View 5 chunks +52 lines, -64 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/connection_manager_unittest.cc View 10 chunks +15 lines, -31 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/core.h View 6 chunks +4 lines, -22 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/core.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/core_test_base.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/core_test_base.cc View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/master_connection_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/master_connection_manager.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M third_party/mojo/src/mojo/edk/test/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
A third_party/mojo/src/mojo/public/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/VERSION View 1 chunk +1 line, -1 line 0 comments Download
A third_party/mojo/src/mojo/public/c/DEPS View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/c/gles2/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/c/system/buffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/c/system/data_pipe.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/c/system/functions.h View 3 chunks +6 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/public/c/system/message_pipe.h View 3 chunks +26 lines, -24 lines 0 comments Download
M third_party/mojo/src/mojo/public/c/system/tests/core_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/c/system/types.h View 1 chunk +1 line, -2 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/DEPS View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/README.md View 1 chunk +1 line, -1 line 0 comments Download
A third_party/mojo/src/mojo/public/cpp/application/DEPS View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/application/application_impl.h View 2 chunks +9 lines, -8 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/application/lib/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/application/lib/application_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/application/lib/application_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/application/lib/service_registry.cc View 1 chunk +1 line, -3 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/lib/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/string.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/struct_ptr.h View 1 chunk +0 lines, -1 line 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/tests/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/environment/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/environment/lib/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/test_support/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/utility/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/utility/run_loop.h View 2 chunks +2 lines, -13 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/core.dart View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/rules.gni View 1 chunk +0 lines, -112 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/application.dart View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/codec.dart View 16 chunks +33 lines, -115 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/handle_watcher.dart View 4 chunks +8 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/message.dart View 2 chunks +2 lines, -37 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/message_pipe.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/proxy.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/service_provider.dart View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/stub.dart View 3 chunks +3 lines, -9 lines 0 comments Download
A third_party/mojo/src/mojo/public/dart/src/timer_impl.dart View 1 chunk +333 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/bindings/decoder.go View 5 chunks +5 lines, -52 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/bindings/encoder.go View 6 chunks +10 lines, -11 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/bindings/invalid_handle.go View 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/bindings/util.go View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/test_structs.mojom View 5 chunks +10 lines, -22 lines 0 comments Download
A + third_party/mojo/src/mojo/public/tests/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/interface_definition.tmpl View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/struct_definition.tmpl View 2 chunks +6 lines, -9 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/go_templates/source.tmpl View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_dart_generator.py View 2 chunks +4 lines, -4 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_go_generator.py View 1 chunk +0 lines, -51 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_java_generator.py View 4 chunks +8 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/mojom.gni View 5 chunks +1 line, -43 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/mojom_bindings_generator.py View 4 chunks +4 lines, -7 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/fileutil.py View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/data.py View 14 chunks +28 lines, -53 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/generator.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/module.py View 10 chunks +27 lines, -69 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/pack.py View 2 chunks +0 lines, -42 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/parse/translate.py View 4 chunks +32 lines, -63 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom_tests/fileutil_unittest.py View 1 chunk +0 lines, -55 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom_tests/generate/data_unittest.py View 2 chunks +4 lines, -0 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom_tests/generate/pack_unittest.py View 1 chunk +0 lines, -54 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom_tests/parse/translate_unittest.py View 1 chunk +4 lines, -3 lines 0 comments Download
A third_party/mojo_services/src/geometry/public/cpp/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/mojo_services/src/gpu/public/interfaces/command_buffer.mojom View 2 chunks +8 lines, -10 lines 0 comments Download
A third_party/mojo_services/src/native_viewport/public/cpp/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/mojo_services/src/public/js/application.js View 2 chunks +23 lines, -19 lines 0 comments Download
D third_party/mojo_services/src/public/js/service_exchange.js View 1 chunk +0 lines, -86 lines 0 comments Download
A + third_party/mojo_services/src/public/js/service_provider.js View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/mojo_services/src/public/js/shell.js View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/mojo_services/src/public/sky/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A third_party/mojo_services/src/surfaces/public/cpp/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/mojo_services/src/surfaces/public/interfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo_services/src/surfaces/public/interfaces/surfaces.mojom View 1 chunk +9 lines, -16 lines 0 comments Download
A third_party/mojo_services/src/surfaces/public/interfaces/surfaces_service.mojom View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/mojo_services/src/view_manager/public/cpp/DEPS View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/mojo_services/src/view_manager/public/cpp/lib/DEPS View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/mojo_services/src/view_manager/public/cpp/lib/view.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo_services/src/view_manager/public/cpp/lib/view_manager_client_impl.h View 5 chunks +11 lines, -10 lines 0 comments Download
M third_party/mojo_services/src/view_manager/public/cpp/lib/view_manager_client_impl.cc View 6 chunks +21 lines, -23 lines 0 comments Download
M third_party/mojo_services/src/view_manager/public/cpp/tests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A third_party/mojo_services/src/view_manager/public/cpp/tests/DEPS View 1 chunk +16 lines, -0 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/tests/run_all_unittests.cc View 1 chunk +0 lines, -14 lines 0 comments Download
A + third_party/mojo_services/src/view_manager/public/cpp/tests/view_manager_unittests.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/mojo_services/src/view_manager/public/cpp/view_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo_services/src/window_manager/public/interfaces/window_manager.mojom View 1 chunk +7 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
5 years, 10 months ago (2015-02-06 23:41:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877993004/1
5 years, 10 months ago (2015-02-06 23:44:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 23:46:19 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 23:46:59 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0e5adf14aee00d99270cfe780a4364474e952912
Cr-Commit-Position: refs/heads/master@{#315134}

Powered by Google App Engine
This is Rietveld 408576698