Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: third_party/mojo/src/mojo/edk/system/channel.h

Issue 877993004: Revert "Update mojo sdk to rev 8d45c89c30b230843c5bd6dd0693a555750946c0" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/mojo/src/mojo/edk/system/DEPS ('k') | third_party/mojo/src/mojo/edk/system/channel_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/mojo/src/mojo/edk/system/channel.h
diff --git a/third_party/mojo/src/mojo/edk/system/channel.h b/third_party/mojo/src/mojo/edk/system/channel.h
index 93ba87ae95743ec56b7b4ec91a1a4c766a8f1c89..396185908dd48b1f989425198bb61ac00a66e6f8 100644
--- a/third_party/mojo/src/mojo/edk/system/channel.h
+++ b/third_party/mojo/src/mojo/edk/system/channel.h
@@ -54,7 +54,8 @@ class MOJO_SYSTEM_IMPL_EXPORT Channel
: public base::RefCountedThreadSafe<Channel>,
public RawChannel::Delegate {
public:
- // |platform_support| must remain alive until after |Shutdown()| is called.
+ // |platform_support| (typically owned by |Core|) must remain alive until
+ // after |Shutdown()| is called.
explicit Channel(embedder::PlatformSupport* platform_support);
// This must be called on the creation thread before any other methods are
@@ -64,9 +65,7 @@ class MOJO_SYSTEM_IMPL_EXPORT Channel
// Sets the channel manager associated with this channel. This should be set
// at most once and only called before |WillShutdownSoon()| (and
- // |Shutdown()|). (This is called by the channel manager when adding a
- // channel; this should not be called before the channel is managed by the
- // channel manager.)
+ // |Shutdown()|).
void SetChannelManager(ChannelManager* channel_manager);
// This must be called on the creation thread before destruction (which can
« no previous file with comments | « third_party/mojo/src/mojo/edk/system/DEPS ('k') | third_party/mojo/src/mojo/edk/system/channel_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698