third_party/mojo/src/mojo/public/tools/bindings/mojom_bindings_generator.py - Issue 877993004: Revert "Update mojo sdk to rev 8d45c89c30b230843c5bd6dd0693a555750946c0"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mojo/src/mojo/public/tools/bindings/mojom_bindings_generator.py

Issue 877993004: Revert "Update mojo sdk to rev 8d45c89c30b230843c5bd6dd0693a555750946c0" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/mojo/src/mojo/public/tools/bindings/mojom.gni ('k') | third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/fileutil.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/mojo/src/mojo/public/tools/bindings/mojom_bindings_generator.py

diff --git a/third_party/mojo/src/mojo/public/tools/bindings/mojom_bindings_generator.py b/third_party/mojo/src/mojo/public/tools/bindings/mojom_bindings_generator.py

index 0498838a865974946208ed7fc7436f26622c6a00..2d1802c05ac6ec723c86f8f6a312a03b97efcd98 100755

--- a/third_party/mojo/src/mojo/public/tools/bindings/mojom_bindings_generator.py

+++ b/third_party/mojo/src/mojo/public/tools/bindings/mojom_bindings_generator.py

@@ -34,7 +34,6 @@ sys.path.insert(0, os.path.join(os.path.dirname(os.path.abspath(__file__)),

"pylib"))

from mojom.error import Error

-import mojom.fileutil as fileutil

from mojom.generate.data import OrderedModuleFromData

from mojom.parse.parser import Parse

from mojom.parse.translate import Translate

@@ -51,12 +50,9 @@ def LoadGenerators(generators_string):

if generator_name.lower() == "c++":

generator_name = os.path.join(script_dir, "generators",

"mojom_cpp_generator.py")

- elif generator_name.lower() == "dart":

+ if generator_name.lower() == "dart":

generator_name = os.path.join(script_dir, "generators",

"mojom_dart_generator.py")

- elif generator_name.lower() == "go":

- generator_name = os.path.join(script_dir, "generators",

- "mojom_go_generator.py")

elif generator_name.lower() == "javascript":

generator_name = os.path.join(script_dir, "generators",

"mojom_js_generator.py")

@@ -195,7 +191,7 @@ def main():

help="output directory for generated files")

parser.add_argument("-g", "--generators", dest="generators_string",

metavar="GENERATORS",

- default="c++,dart,go,javascript,java,python",

+ default="c++,dart,javascript,java,python",

help="comma-separated list of generators")

parser.add_argument("--debug_print_intermediate", action="store_true",

help="print the intermediate representation")

@@ -208,7 +204,8 @@ def main():

generator_modules = LoadGenerators(args.generators_string)

- fileutil.EnsureDirectoryExists(args.output_dir)

+ if not os.path.exists(args.output_dir):

+ os.makedirs(args.output_dir)

processor = MojomProcessor(lambda filename: filename in args.filename)

for filename in args.filename: