Issue 877363002: Add Herb to AUTHORS file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 877363002: Add Herb to AUTHORS file

Created:
5 years, 10 months ago by rmistry

Modified:
5 years, 10 months ago

Reviewers:
hcm

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Add Herb to AUTHORS file NOTRY=true BUG=skia:

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	AUTHORS	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmistry

Also this raises the question of if the email herbderby@gmail.com needs to sign the CLA.

5 years, 10 months ago (2015-01-28 13:37:29 UTC) #3

hcm

5 years, 10 months ago (2015-01-28 14:28:07 UTC) #4

On 2015/01/28 13:37:29, rmistry wrote:
> Also this raises the question of if the email mailto:herbderby@gmail.com needs
to sign
> the CLA.

Good question- actually I put up a CL to add him and also fix some of the
organization last night if we want to use that one:
https://codereview.chromium.org/881993002

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages