Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 881993002: authors update- add herb and reorganize (Closed)

Created:
5 years, 11 months ago by hcm
Modified:
5 years, 10 months ago
Reviewers:
rmistry, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

authors update- add herb and reorganize BUG=skia: TBR=reed@google.com NOTRY=true Committed: https://skia.googlesource.com/skia/+/45453c2acfa39755081616fd9c02e567b3369d40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M AUTHORS View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmistry
On 2015/01/28 14:27:25, hcm wrote: > mailto:hcm@google.com changed reviewers: > + mailto:rmistry@google.com As mentioned in ...
5 years, 10 months ago (2015-01-28 14:30:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881993002/1
5 years, 10 months ago (2015-01-28 22:16:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/45453c2acfa39755081616fd9c02e567b3369d40
5 years, 10 months ago (2015-01-28 22:16:49 UTC) #5
hcm
5 years, 10 months ago (2015-01-28 22:21:53 UTC) #6
Message was sent while issue was closed.
On 2015/01/28 14:30:31, rmistry wrote:
> On 2015/01/28 14:27:25, hcm wrote:
> > mailto:hcm@google.com changed reviewers:
> > + mailto:rmistry@google.com
> 
> As mentioned in https://codereview.chromium.org/877363002/:
> We should find out if our gmail accounts need to sign the CLA for us to submit
> code using them. Google knows that http://google.com and http://chromium.org
accounts are ours
> but there is AFAIK no way to connect personal accounts with them.

Pushed this in as agreed for now, we are abiding by the rules of making sure all
authors are listed/authorized/covered by a CLA.. I don't think we want
individuals signing CLAs who are already covered by Google or another
corporation's CLA, it seems we just need a way to keep track of additional
aliases for approved authors.  Will work on this and fold it into our plans
around automated checks as well.

Powered by Google App Engine
This is Rietveld 408576698