Issue 877333002: Fix build flakes in GN build due to wrong deps for grit action.

Issue 877333002: Fix build flakes in GN build due to wrong deps for grit action. (Closed)

Created:
5 years, 10 months ago by Slava Chigrin

Modified:
5 years, 10 months ago

Reviewers:
Dirk Pranke, brettw

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix build flakes in GN build due to wrong deps for grit action. BUG=452847 Committed: https://crrev.com/8eede94a17bd84717a34b9f7e83690a8ef4e3d15 Cr-Commit-Position: refs/heads/master@{#313684}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	build/secondary/tools/grit/grit_rule.gni	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
	M	chrome/browser/BUILD.gn	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 8 (3 generated)

Slava Chigrin

Sorry, seems, I broke the build in https://codereview.chromium.org/876783003/ . Seems, data_deps is not enough to ...

5 years, 10 months ago (2015-01-28 12:39:33 UTC) #2

brettw

LGTM Yeah, data deps is just a runtime thing ("should be available when the build ...

5 years, 10 months ago (2015-01-29 02:00:40 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877333002/40001

5 years, 10 months ago (2015-01-29 08:52:58 UTC) #6

commit-bot: I haz the power

5 years, 10 months ago (2015-01-29 09:29:38 UTC) #8

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/8eede94a17bd84717a34b9f7e83690a8ef4e3d15
Cr-Commit-Position: refs/heads/master@{#313684}