build/secondary/tools/grit/grit_rule.gni - Issue 877333002: Fix build flakes in GN build due to wrong deps for grit action.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/secondary/tools/grit/grit_rule.gni

Issue 877333002: Fix build flakes in GN build due to wrong deps for grit action. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase after revert of original, problematic CL. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/secondary/tools/grit/grit_rule.gni

diff --git a/build/secondary/tools/grit/grit_rule.gni b/build/secondary/tools/grit/grit_rule.gni

index 7a1cc267475ecd281ce3fb0643effa2c78690bf3..cdaf0f272282f693ecd36763f2cae92f8e275097 100644

--- a/build/secondary/tools/grit/grit_rule.gni

+++ b/build/secondary/tools/grit/grit_rule.gni

@@ -54,6 +54,8 @@

# If set, output_dir is not added to include_dirs.

# deps (optional)

+# inputs (optional)

+# List of additional files, required for grit to process source file.

# visibility (optional)

# Normal meaning.

@@ -413,6 +415,9 @@ template("grit") {

if (defined(invoker.deps)) {

deps += invoker.deps

}

+ if (defined(invoker.inputs)) {

+ inputs += invoker.inputs

+ }

}

# This is the thing that people actually link with, it must be named the

« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »