chrome/browser/BUILD.gn - Issue 877333002: Fix build flakes in GN build due to wrong deps for grit action.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/BUILD.gn

Issue 877333002: Fix build flakes in GN build due to wrong deps for grit action. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase after revert of original, problematic CL. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/BUILD.gn

diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn

index 359702ddade11c8e3112077741e822101a23a25d..e5e14286679f00ca518c180a2309df3e51a71bfb 100644

--- a/chrome/browser/BUILD.gn

+++ b/chrome/browser/BUILD.gn

@@ -803,8 +803,9 @@ grit("resources") {

deps = [

":about_credits",

":chrome_internal_resources_gen",

- "//chrome/browser/ui/webui/omnibox:mojo_bindings",

- "//mojo/environment:chromium",

+ ]

+ inputs = [

+ omnibox_mojom_file,

]

}

« no previous file with comments | « build/secondary/tools/grit/grit_rule.gni ('k') | no next file » | no next file with comments »