Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 876323002: Fix i18nsupport=off standalone build. (Closed)

Created:
5 years, 9 months ago by bnoordhuis
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Visibility:
Public.

Description

Fix i18nsupport=off standalone build.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M Makefile View 3 chunks +19 lines, -11 lines 3 comments Download

Messages

Total messages: 6 (2 generated)
bnoordhuis
* fix i18nsupport=off * fix building with gcc https://codereview.chromium.org/876323002/diff/1/Makefile File Makefile (right): https://codereview.chromium.org/876323002/diff/1/Makefile#newcode56 Makefile:56: ifeq ...
5 years, 9 months ago (2015-01-27 14:46:55 UTC) #2
Benedikt Meurer
Better reviewer selection...
5 years, 9 months ago (2015-01-27 14:48:00 UTC) #4
Jakob Kummerow
This is for people who refuse to run "gclient sync", right? Not sure we even ...
5 years, 9 months ago (2015-01-27 15:01:20 UTC) #5
jochen (gone - plz use gerrit)
5 years, 9 months ago (2015-01-27 15:11:28 UTC) #6
i agree that supporting non-standard checkouts is just asking for trouble.
Please use fetch v8 / gclient sync to create a checkout.

Powered by Google App Engine
This is Rietveld 408576698