Fix i18nsupport=off standalone build.

Makefile

 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 19 matching lines @@
 OUTDIR ?= out
 TESTJOBS ?=
 GYPFLAGS ?=
 TESTFLAGS ?=
 ANDROID_NDK_ROOT ?=
 ANDROID_NDK_HOST_ARCH ?=
 ANDROID_TOOLCHAIN ?=
 ANDROID_V8 ?= /data/local/tmp/v8
 NACL_SDK_ROOT ?=
 
+# List of files that trigger Makefile regeneration:
+GYPFILES = build/shim_headers.gypi build/features.gypi build/standalone.gypi \
+           build/toolchain.gypi build/all.gyp build/mac/asan.gyp \
+           build/android.gypi test/cctest/cctest.gyp \
+           test/unittests/unittests.gyp tools/gyp/v8.gyp \
+           tools/parser-shell.gyp testing/gmock.gyp testing/gtest.gyp \
+           samples/samples.gyp \
+           src/third_party/vtune/v8vtune.gyp src/d8.gyp
+
 # Special build flags. Use them like this: "make library=shared"
 
 # library=shared || component=shared_library

[Jakob Kummerow, 2015/01/27 15:01:20]

+1 to alphabetical sorting, but please move the "component=shared_library" part
of this comment where it belongs now (i.e. before "ifdef component").

 ifeq ($(library), shared)
   GYPFLAGS += -Dcomponent=shared_library
 endif
+# clang=on
+ifeq ($(clang), on)

[bnoordhuis, 2015/01/27 14:46:54]

Maybe this should check for 'off', to keep the default `make` behavior the same?

[Jakob Kummerow, 2015/01/27 15:01:20]

Absolutely. Not specifying anything should build with clang. In fact, you don't
need -Dclang=1 in that case.

+  GYPFILES += buildtools/third_party/libc++abi/libc++abi.gyp \
+              buildtools/third_party/libc++/libc++.gyp
+  GYPFLAGS += -Dclang=1
+else
+  GYPFLAGS += -Dclang=0
+endif
 ifdef component
   GYPFLAGS += -Dcomponent=$(component)
 endif
 # console=readline
 ifdef console
   GYPFLAGS += -Dconsole=$(console)
 endif
 # disassembler=on
 ifeq ($(disassembler), on)
   GYPFLAGS += -Dv8_enable_disassembler=1
@@ skipping 77 matching lines @@
   GYPFLAGS += -Dv8_no_strict_aliasing=1
 endif
 # regexp=interpreted
 ifeq ($(regexp), interpreted)
   GYPFLAGS += -Dv8_interpreted_regexp=1
 endif
 # i18nsupport=off
 ifeq ($(i18nsupport), off)
   GYPFLAGS += -Dv8_enable_i18n_support=0
   TESTFLAGS += --noi18n
+else
+  GYPFILES += third_party/icu/icu.gypi third_party/icu/icu.gyp
 endif
 # deprecation_warnings=on
 ifeq ($(deprecationwarnings), on)
   GYPFLAGS += -Dv8_deprecation_warnings=1
 endif
 # asan=on
 ifeq ($(asan), on)
   GYPFLAGS += -Dasan=1 -Dclang=1
   TESTFLAGS += --asan
   ifeq ($(lsan), on)
@@ skipping 77 matching lines @@
 
 # Architectures and modes to be compiled. Consider these to be internal
 # variables, don't override them (use the targets instead).
 ARCHES = ia32 x64 x32 arm arm64 mips mipsel mips64el x87 ppc ppc64
 DEFAULT_ARCHES = ia32 x64 arm
 MODES = release debug optdebug
 DEFAULT_MODES = release debug
 ANDROID_ARCHES = android_ia32 android_arm android_arm64 android_mipsel android_x87
 NACL_ARCHES = nacl_ia32 nacl_x64
 
-# List of files that trigger Makefile regeneration:
-GYPFILES = third_party/icu/icu.gypi third_party/icu/icu.gyp \
-           build/shim_headers.gypi build/features.gypi build/standalone.gypi \
-           build/toolchain.gypi build/all.gyp build/mac/asan.gyp \
-           build/android.gypi test/cctest/cctest.gyp \
-           test/unittests/unittests.gyp tools/gyp/v8.gyp \
-           tools/parser-shell.gyp testing/gmock.gyp testing/gtest.gyp \
-           buildtools/third_party/libc++abi/libc++abi.gyp \
-           buildtools/third_party/libc++/libc++.gyp samples/samples.gyp \
-           src/third_party/vtune/v8vtune.gyp src/d8.gyp
-
 # If vtunejit=on, the v8vtune.gyp will be appended.
 ifeq ($(vtunejit), on)
   GYPFILES += src/third_party/vtune/v8vtune.gyp
 endif
 # Generates all combinations of ARCHES and MODES, e.g. "ia32.release".
 BUILDS = $(foreach mode,$(MODES),$(addsuffix .$(mode),$(ARCHES)))
 ANDROID_BUILDS = $(foreach mode,$(MODES), \
                    $(addsuffix .$(mode),$(ANDROID_ARCHES)))
 NACL_BUILDS = $(foreach mode,$(MODES), \
                    $(addsuffix .$(mode),$(NACL_ARCHES)))
@@ skipping 229 matching lines @@
 # We need to manually set the stack limit here, to work around bugs in
 # gmake-3.81 and global-5.7.1 on recent 64-bit Linux systems.
 GPATH GRTAGS GSYMS GTAGS: gtags.files $(shell cat gtags.files 2> /dev/null)
         @bash -c 'ulimit -s 10240 && GTAGSFORCECPP=yes gtags -i -q -f $<'
 
 gtags.clean:
         rm -f gtags.files GPATH GRTAGS GSYMS GTAGS
 
 dependencies builddeps:
         $(error Use 'gclient sync' instead)