Issue 876313009: Keep an instance of QuicAckFrame in QuicConnection in order to reduce

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 876313009: Keep an instance of QuicAckFrame in QuicConnection in order to reduce (Closed)

Created:
5 years, 10 months ago by ramant (doing other things)

Modified:
5 years, 10 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Fix_compile_errors_85182632

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Keep an instance of QuicAckFrame in QuicConnection in order to reduce memory allocations. Saves 1.5% of the CPU according to profiles. May be slightly more on clients. Merge internal change: 85351635 R=rch@chromium.org

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -76 lines)			Patch
M	net/quic/quic_connection.h	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	net/quic/quic_connection.cc	View	2 chunks	+8 lines, -16 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	2 chunks	+6 lines, -7 lines	0 comments	Download
M	net/quic/quic_packet_generator.h	View	2 chunks	+9 lines, -4 lines	0 comments	Download
M	net/quic/quic_packet_generator.cc	View	4 chunks	+14 lines, -10 lines	0 comments	Download
M	net/quic/quic_packet_generator_test.cc	View	8 chunks	+9 lines, -24 lines	0 comments	Download
M	net/quic/quic_received_packet_manager.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/quic/test_tools/quic_connection_peer.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	net/quic/test_tools/quic_connection_peer.cc	View	1 chunk	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages