Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: net/quic/quic_connection.h

Issue 876313009: Keep an instance of QuicAckFrame in QuicConnection in order to reduce (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Fix_compile_errors_85182632
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.h
diff --git a/net/quic/quic_connection.h b/net/quic/quic_connection.h
index ddeb4677f00b1f880a6a6c1a6185be892e9aa9e6..e944aea51951a473b7b1dafc5f6bc21e86a2dbb2 100644
--- a/net/quic/quic_connection.h
+++ b/net/quic/quic_connection.h
@@ -370,8 +370,8 @@ class NET_EXPORT_PRIVATE QuicConnection
bool ShouldGeneratePacket(TransmissionType transmission_type,
HasRetransmittableData retransmittable,
IsHandshake handshake) override;
- QuicAckFrame* CreateAckFrame() override;
- QuicStopWaitingFrame* CreateStopWaitingFrame() override;
+ void PopulateAckFrame(QuicAckFrame* ack) override;
+ void PopulateStopWaitingFrame(QuicStopWaitingFrame* stop_waiting) override;
void OnSerializedPacket(const SerializedPacket& packet) override;
// QuicSentPacketManager::NetworkChangeVisitor
@@ -629,9 +629,6 @@ class NET_EXPORT_PRIVATE QuicConnection
void ProcessStopWaitingFrame(const QuicStopWaitingFrame& stop_waiting);
- // Update |stop_waiting| for an outgoing ack.
- void UpdateStopWaiting(QuicStopWaitingFrame* stop_waiting);
-
// Queues an ack or sets the ack alarm when an incoming packet arrives that
// should be acked.
void MaybeQueueAck();
« no previous file with comments | « no previous file | net/quic/quic_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698